#49 Added export_slc_async fixture #50
Conversation
|
|
||
| return func | ||
| language_alias=slc_builder.language_alias) | ||
| deployer.run(container_file=export_slc, alter_system=True, allow_override=True) |
There was a problem hiding this comment.
Question is do we need to clean up. Meaning removing the the slc and resetting the language definitions for the system. And maybe we actually want to use the file name we get from export_slc for the filename in the bucketfs. I am actually not sure if the deployer does support this at moment. However, if we do it we could cache the uploaded file.
There was a problem hiding this comment.
And, another question, do we wait here for the upload?
There was a problem hiding this comment.
At the moment the deployer doesn't support the cleanup. There is a ticket for that.
Yes, uploading the container is a blocking operation.
There was a problem hiding this comment.
Ok, so the cleanup is something we can improve later
|
|
||
| The operation will be skipped if none of the backends is in use. | ||
| """ | ||
| if (not (use_onprem or use_saas)) or (slc_builder is None): |
There was a problem hiding this comment.
Maybe it makes also sense to add a cli option to enable building specifically also when no backend is enabled for tests that only inspect the tar archive. But, I think we can add this also later, when we see the need for it.
There was a problem hiding this comment.
I agree with the last statement :). We do need to test the container building and uploading, but the code for that is in the python-extension-common. We cannot use this plugin there as it would create a circular reference.
There was a problem hiding this comment.
PEC needs to test some general things. I meant more, if a extension needs add special things to the language container and wants to check if they are where they should be. But as we agree we can figure that out later.
closes #49