Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#49 Added export_slc_async fixture #50
#49 Added export_slc_async fixture #50
Changes from all commits
fd44ea1
81bef2e
ca1c52d
19d9646
eb9132e
f34544a
6f66074
5222645
9f08687
94d963b
d78b4d8
90ee5a7
119cad5
b0dab6b
b5a08d6
b6235ba
5d24cd5
6292e49
c26dc80
2a39190
cb10b2d
d0c274c
fc4b301
54356e2
54853b3
1993d06
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it makes also sense to add a cli option to enable building specifically also when no backend is enabled for tests that only inspect the tar archive. But, I think we can add this also later, when we see the need for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the last statement :). We do need to test the container building and uploading, but the code for that is in the python-extension-common. We cannot use this plugin there as it would create a circular reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEC needs to test some general things. I meant more, if a extension needs add special things to the language container and wants to check if they are where they should be. But as we agree we can figure that out later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question is do we need to clean up. Meaning removing the the slc and resetting the language definitions for the system. And maybe we actually want to use the file name we get from export_slc for the filename in the bucketfs. I am actually not sure if the deployer does support this at moment. However, if we do it we could cache the uploaded file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, another question, do we wait here for the upload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment the deployer doesn't support the cleanup. There is a ticket for that.
Yes, uploading the container is a blocking operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so the cleanup is something we can improve later