Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#950: refactor options line parser v2 #448

Merged
merged 20 commits into from
Sep 20, 2024
Merged

#950: refactor options line parser v2 #448

merged 20 commits into from
Sep 20, 2024

Conversation

tomuben
Copy link
Collaborator

@tomuben tomuben commented Sep 6, 2024

No description provided.

@tomuben tomuben force-pushed the refactoring/950_refactor_options_line_parser_v2 branch from 63b7362 to b17d98b Compare September 17, 2024 11:11
tkilias
tkilias reviewed Sep 19, 2024
View reviewed changes
exaudfclient/base/javacontainer/script_options/converter.cc
if (nextImportStatement.first == "")
void Converter::convertJvmOption(const std::string & value) {
for (size_t start = 0, delim = 0; ; start = delim + 1) {
start = value.find_first_not_of(m_whitespace, start);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we need to later see, how we deal with white spaces in the jvm option

@tomuben tomuben merged commit 3233961 into master Sep 20, 2024
9 checks passed
@tomuben tomuben deleted the refactoring/950_refactor_options_line_parser_v2 branch September 20, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomuben @tkilias