-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#950: refactor options line parser v2 #448
Merged
tomuben
merged 20 commits into
master
from
refactoring/950_refactor_options_line_parser_v2
Sep 20, 2024
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
910d47e
Refactoring
tomuben d71a3b1
More refactoring
tomuben 5641fa6
More refactoring
tomuben 2736c72
Fixes
tomuben 0baf98c
Fixes
tomuben 3deb7ae
Passe script code as function parameter.
tomuben 04e9509
Added SwigMetaDataIf interface
tomuben 19c2e67
Use std::unique_ptr for MetaData
tomuben 9f76f4c
Use std::unique_ptr for Parser
tomuben b17d98b
Moved instantiation of Script Options parser into factory.
tomuben 86c8b06
Set script code for parser in constructor (again)
tomuben 9b2c070
Use script code for check for duplicates
tomuben d6e57d1
Moved script import handling into parser
tomuben f9b3597
1. Fixed scriptclass, jvmOptions and jarPaths
tomuben c20fc0e
Added a github workflow step to build Python3 and Java UDF Client
tomuben bdf42d2
Fixed bazel tests GH workflow
tomuben d8a025d
Removed bazel build in check_bazel_tests.yml
tomuben bafeba9
Added more documentation to ScriptOptionLinesParserLegacy::extractImp…
tomuben a425887
Fixes from review
tomuben 71e093c
Added documentation for ScriptOptionsParser::extractImportScripts
tomuben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
exaudfclient/base/javacontainer/script_options/checksum.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#include "base/javacontainer/script_options/checksum.h" | ||
#include <openssl/md5.h> | ||
#include <string.h> | ||
|
||
namespace SWIGVMContainers { | ||
|
||
namespace JavaScriptOptions { | ||
|
||
inline std::vector<unsigned char> scriptToMd5(const char *script) { | ||
MD5_CTX ctx; | ||
unsigned char md5[MD5_DIGEST_LENGTH]; | ||
MD5_Init(&ctx); | ||
MD5_Update(&ctx, script, strlen(script)); | ||
MD5_Final(md5, &ctx); | ||
return std::vector<unsigned char>(md5, md5 + sizeof(md5)); | ||
} | ||
|
||
|
||
bool Checksum::addScript(const char *script) { | ||
return m_importedScriptChecksums.insert(scriptToMd5(script)).second; | ||
} | ||
|
||
|
||
} //namespace JavaScriptOptions | ||
|
||
} //namespace SWIGVMContainers |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#ifndef SCRIPTOPTIONLINEPARSERCHECKSUM_H | ||
#define SCRIPTOPTIONLINEPARSERCHECKSUM_H 1 | ||
|
||
#include <string> | ||
#include <vector> | ||
#include <set> | ||
|
||
|
||
namespace SWIGVMContainers { | ||
|
||
namespace JavaScriptOptions { | ||
|
||
class Checksum { | ||
|
||
public: | ||
Checksum() = default; | ||
|
||
bool addScript(const char *script); | ||
|
||
private: | ||
std::set<std::vector<unsigned char> > m_importedScriptChecksums; | ||
}; | ||
|
||
|
||
} //namespace JavaScriptOptions | ||
|
||
} //namespace SWIGVMContainers | ||
|
||
#endif //SCRIPTOPTIONLINEPARSERCHECKSUM_H |
133 changes: 32 additions & 101 deletions
133
exaudfclient/base/javacontainer/script_options/converter.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we need to later see, how we deal with white spaces in the jvm option