Review all changes incl. MVP #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comment Schema must be uppercase for snowflake
- fixed "no database context issue" on new snowflake test account by attempting to create new database every time making the tests more resilient
- timestamp with timezone -> timezone - warning for NUMBER with precision > 36 - 'character' is an alias for varchar in snowflake so it gets converted to varchar and there's no padding
kaklakariada
approved these changes
Oct 1, 2024
doc/changes/changes_0.1.0.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Virtual Schema for Snowflake 0.1.0, released 2024-09-26 | |||
| # Virtual Schema for Snowflake 0.1.0, released 2024-09-27 | |||
There was a problem hiding this comment.
Suggested change
| # Virtual Schema for Snowflake 0.1.0, released 2024-09-27 | |
| # Virtual Schema for Snowflake 0.1.0, released 2024-10-01 |
kaklakariada
approved these changes
Oct 1, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.