fix: MEMORY LEAK #1120
Open
fix: MEMORY LEAK #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One important caveat was ignored by piping request stream to busboy stream. This commit aknowledges that caveat. More information on: https://nodejs.org/api/stream.html#readablepipedestination-options
As mentioned by @Gerard-Szulc we use `removeListener` in node instead of `removeEventListener`
LinusU
reviewed
Oct 30, 2022
| @@ -42,10 +42,16 @@ function makeMiddleware (setup) { | |||
| var pendingWrites = new Counter() | |||
| var uploadedFiles = [] | |||
|
|
|||
| function requestError(error) { | |||
| if(!busboy) return | |||
There was a problem hiding this comment.
busboy should always be defined here?
Suggested change
| if(!busboy) return |
LinusU
reviewed
Oct 30, 2022
| @@ -42,10 +42,16 @@ function makeMiddleware (setup) { | |||
| var pendingWrites = new Counter() | |||
| var uploadedFiles = [] | |||
|
|
|||
| function requestError(error) { | |||
There was a problem hiding this comment.
Suggested change
| function requestError(error) { | |
| function requestError (error) { |
|
Sorry for the late reply, this looks good 👍 Only have one question, will the |
|
Bump |
|
@LinusU Merger? |
|
@LinusU Can you please merge this? Servers that use |
|
Bump, can we merge this please? |
didiercolens
added a commit
to didiercolens/bdb-multer
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One important caveat was ignored by piping request stream to busboy stream. This commit aknowledges that caveat by closing busboy stream when request stream encounters an error. More information about this caveat can be found on https://nodejs.org/api/stream.html#readablepipedestination-options.
This PR also fixes multiple issues that are caused by this caveat some are listed blow.
Some PR's (that may introduce breaking changes) are closed by this PR also (without breaking changes) and some are listed blow.
PLEASE MERGE THIS BECAUSE IT'S INSANE ANNOYING HAVING TO RELAUNCH THE SERVER EVERY DAY BECAUSE THOUSANDS OF OPEN STREAMS ARE NOT CLOSED (MEMORY LEAKS)
@LinusU here is a not breaking change that will fix all the above.