Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MEMORY LEAK #1120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Open

fix: MEMORY LEAK #1120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
274b2b4
fix: busboy not closed when request errors
UnlimitedBytes Jul 10, 2022
6fe2936
fix: change removeEventListener to removeListener
UnlimitedBytes Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/make-middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,16 @@ function makeMiddleware (setup) {
var pendingWrites = new Counter()
var uploadedFiles = []

function requestError(error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function requestError(error) {
function requestError (error) {

if(!busboy) return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

busboy should always be defined here?

Suggested change
if(!busboy) return

busboy.destroy(error)
}

function done (err) {
if (isDone) return
isDone = true

req.removeListener('error', requestError)
req.unpipe(busboy)
drainStream(req)
busboy.removeAllListeners()
Expand Down Expand Up @@ -174,6 +180,7 @@ function makeMiddleware (setup) {
indicateDone()
})

req.on('error', requestError)
req.pipe(busboy)
}
}
Expand Down