Ephemeral Categories & Modal Confirmations

[JasonWarrenUK]

NOW WITH NEW UPDATED FEATURES!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!111111!!!

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Styling
• Build
• Chore

Description

• Categories are discarded if user cancels tool creation
• Creating new category but deselecting it before creating a tool checks for appropriate action
• Cancelling tool creation will display alert if the user has input any values
• Refactor all non-error messages addTool components to use Modals
• Added optional click handler to NavLink that allows for a Modal before navigation

NEWW AnD 1MPR0VD

• restyled modals
• updated all add tool logic to use database import
• rewrote tests to look for error modals
• replaced NavLink with Button

Screenshots

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Semantic HTML implemented?
• Checked with axe DevTools and addressed Critical and Serious issues?
• Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

• Yes
• No, and this is why: It's late, my meds have worn off, and if I don't make this PR now then it won't be made until tomorrow
• I need help with writing tests

Delete branch after merge?

• [XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX] Yes
• No

What gif best describes this PR or how it makes you feel?

[netlify]

✅ Deploy Preview for thingswedo ready!

Name	Link
🔨 Latest commit	c066943
🔍 Latest deploy log	https://app.netlify.com/sites/thingswedo/deploys/6758569295bc0f0008eb7b25
😎 Deploy Preview	https://deploy-preview-65--thingswedo.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jackcasstlesjones]

• Please refactor so the styling is more in line with the overall app's design
• Probably need to rethink the use of NavLink in AddToolInputs.tsx
• Please also delete the hover effects from CategoriesBar.tsx as this is resulting in unwanted UI behaviour during testing
• Make sure to add a screenshot to the PR description for every UI change that has been made, atm there is only one even though several modal views have been created
• Please remove any alerts and replace them with modals

[JasonWarrenUK]

• Please refactor so the styling is more in line with the overall app's design

Sure. Any specifics I need to consider beyond your comment on the Modal?

• Please also delete the hover effects from CategoriesBar.tsx as this is resulting in unwanted UI behaviour during testing

CategoriesBar.tsx isn't in the scope of this branch and is currently being worked on my Tanya - should this be left to her to avoid conflict and preserve feature/branch/PR scope?

• Make sure to add a screenshot to the PR description for every UI change that has been made, atm there is only one even though several modal views have been created

No prob, sorry about that - was out of time and wanted to get the PR up

[jackcasstlesjones]

I think try to keep buttons through the app on one line only for visual consistency - I think that the Modal text size should maybe be smaller anyway so have a look at that and maybe get team consensus on how it looks.

Happy for you to ask @gurtatiLND to change the hover effects in her branch instead of doing it in yours

Pls feel free to use button for the header in addtool

[JasonWarrenUK]

Happy for you to ask @gurtatiLND to change the hover effects in her branch instead of doing it in yours

I'll do this change, but I'll do that in a separate branch. Just feels odd to tweak unrelated styling in this branch.

Pls feel free to use button for the header in addtool

Will do!

[jackcasstlesjones]

pls