Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add category button #67

Merged
merged 13 commits into from
Dec 10, 2024
Merged

Conversation

gurtatiLND
Copy link
Collaborator

@gurtatiLND gurtatiLND commented Dec 10, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Create a ToolkitDisplay component to act as a container that combines all components required for the toolkit page.
  • Implement a pop-up modal box that is triggered when the user attempts to create a new category from the CategoriesBar.
  • Confirmation and cancel buttons.
  • Ensure the modal integrates seamlessly with the existing CategoriesBar and updates the category list dynamically after a new category is created.

Screenshots

Screenshot 2024-12-09 at 23 08 18 Screenshot 2024-12-10 at 12 58 57

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why:
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 5c2b6fe
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/67585f60a7f2b500082cf7e4
😎 Deploy Preview https://deploy-preview-67--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change pls

src/app/toolkit/components/CategoriesBar.tsx Outdated Show resolved Hide resolved
gurtatiLND and others added 2 commits December 10, 2024 15:31
changed! thank you

Co-authored-by: jackcasstlesjones <[email protected]>
deleted export default from the bottom
@jackcasstlesjones jackcasstlesjones merged commit 02fb6e5 into main Dec 10, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the feat-add-category-button branch December 10, 2024 15:52
maxitect added a commit that referenced this pull request Dec 10, 2024
@maxitect maxitect mentioned this pull request Dec 10, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants