Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit learn page #71

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Toolkit learn page #71

merged 6 commits into from
Dec 11, 2024

Conversation

gurtatiLND
Copy link
Collaborator

@gurtatiLND gurtatiLND commented Dec 11, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Implement a “Learn More” page for the Toolkit tab(take all info from chatGPT analysis, not from Figma) to provide users with detailed explanations. Include navigation to the “Categories” page for filtering and managing toolkit items effectively.

Screenshots

Screenshot 2024-12-11 at 13 39 20 Screenshot 2024-12-11 at 13 39 08 Screenshot 2024-12-11 at 13 39 32

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit aa4c885
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/6759e9f1a3021d00088b87ae
😎 Deploy Preview https://deploy-preview-71--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tanya, good work getting the content in!

The style of the info page is not consistent with the one created for moods (particularly around the header component and heading sizes), see screenshots below

Screen Shot 2024-12-11 at 18 01 16

Screen Shot 2024-12-11 at 18 02 18

Perhaps use the moods learn more page styling classes as a guide so we are more consistent

@gurtatiLND gurtatiLND requested a review from maxitect December 11, 2024 18:42
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question around home/page.tsx file and accessibility/style of headings (hopefully these can just be committed from here as I added suggestions)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is required for this PR, and maybe even for the project? Pending decision to start the app on toolkit, home is just the "/" route and so it is the page.tsx directly under app/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was a mistake, thanks for noticing!! deleted it.

src/app/toolkit/info/CategoriesInfoPage.tsx Outdated Show resolved Hide resolved
src/app/toolkit/info/page.tsx Outdated Show resolved Hide resolved
gurtatiLND and others added 2 commits December 11, 2024 19:34
thank you for noticing!
changed

Co-authored-by: Maxime Downe <[email protected]>
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying those changes!

@maxitect maxitect merged commit 8fba005 into main Dec 11, 2024
5 checks passed
@maxitect maxitect deleted the toolkit-learn-page branch December 11, 2024 20:20
maxitect added a commit that referenced this pull request Dec 12, 2024
@maxitect maxitect mentioned this pull request Dec 13, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants