Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/needs UI #73

Merged
merged 49 commits into from
Dec 11, 2024
Merged

Feature/needs UI #73

merged 49 commits into from
Dec 11, 2024

Conversation

jackcasstlesjones
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones commented Dec 11, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Needs feature UI
  • User going through the Needs questions now updates the mood value in that Need's db document
  • User can navigate forward and back (and quit) through the modal if they make a mistake

Screenshots

Screenshot 2024-12-11 at 18 34 55 Screenshot 2024-12-11 at 18 34 39 Screenshot 2024-12-11 at 18 34 42 Screenshot 2024-12-11 at 18 34 47 Screenshot 2024-12-11 at 18 34 51

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

@jackcasstlesjones
feat: ui for needs
780ca18
@jackcasstlesjones
feat: add subtitle and remove needssection
088fed8
@jackcasstlesjones
Merge branch 'main' into feature/needs-ui
34d7e6e
@jackcasstlesjones
feat: add mock data
87ad6ea
@jackcasstlesjones
chore: change div to fragment
7139537
@jackcasstlesjones
feat: get data but not working properly
e9079b3
@jackcasstlesjones
chore: add key"
57b2e06 
"
@jackcasstlesjones
feat: add pages for needs questions
3bab35b
@jackcasstlesjones
refactor: use question page"
513602e
@jackcasstlesjones
Merge branch 'main' into feature/needs-ui
4a0e701
@jackcasstlesjones
feat: populate page with category names from db
10d7578
@jackcasstlesjones
feat: fetch needs
546801a
@jackcasstlesjones
feat: display needs from db on page
dbedb74
@jackcasstlesjones
feat: display needs better
88d9f1a
@jackcasstlesjones
feat: add console log
c562300
@jackcasstlesjones
feat: add questionsmodal
47c675c
@jackcasstlesjones
refactor: create needs section component
9568c81
@jackcasstlesjones
feat: modal wip
be844c7
@jackcasstlesjones
feat: modal wip 2
0b8e17f
@jackcasstlesjones
feat: modal ui behaviour is working
5a9166b
@jackcasstlesjones
feat: chevron only shows on second and third steps
6a6411c
@jackcasstlesjones
feat: chevron moves forward and back
72a3c78
@jackcasstlesjones
feat: add close button
d062af5
@jackcasstlesjones
style: modal now appears in centre of screen and disables scrolling
7268843
@jackcasstlesjones
chore: fix type errors
9b0fc6c
@jackcasstlesjones
chore: fix more type errors, retrievedataobject now takes generic types
de5928a
@jackcasstlesjones
chore: remove console.logs
3299b50
@jackcasstlesjones
chore: console.logs to track urgency, effort, worthdoing
94bc34a
@jackcasstlesjones
feat: back button functionality works
e8cee94
@jackcasstlesjones
chore: change function names
a9bedb6
@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 020619a
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/675a0738ed0e8a00082474e1
😎 Deploy Preview https://deploy-preview-73--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maxitect
maxitect requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending some deletions, this is good to go, thanks Jack - 1259 lines of code mamma mia!

src/app/needs/questions/page.tsx Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete please

src/lib/db/DatabaseManager.ts Outdated Show resolved Hide resolved
src/lib/db/DatabaseManager.ts Outdated Show resolved Hide resolved
public/mockNeeds.json Outdated Show resolved Hide resolved
@jackcasstlesjones
Copy link
Collaborator Author

Pending some deletions, this is good to go, thanks Jack - 1259 lines of code mamma mia!

454 after deleting that json file lol

maxitect
maxitect approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellento, thanks!

@maxitect maxitect merged commit 7195ac6 into main Dec 11, 2024
5 checks passed
@maxitect maxitect deleted the feature/needs-ui branch December 11, 2024 22:04
maxitect added a commit that referenced this pull request Dec 12, 2024
@maxitect
chore: merge with main pr #71, #73
dc14e73
@maxitect maxitect mentioned this pull request Dec 13, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxitect maxitect maxitect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcasstlesjones @maxitect