-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat home tab #75
Merged
Merged
Feat home tab #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurtatiLND
requested review from
maxitect and
jackcasstlesjones
as code owners
December 12, 2024 14:37
✅ Deploy Preview for thingswedo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jackcasstlesjones
requested changes
Dec 13, 2024
src/ui/shared/HomePage.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed my mind on this if you see it sorry, just move HomePage.tsx
into a components
folder in the src/app
directory, rather than it being in ui/shared
jackcasstlesjones
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
<img>
tags with Next.js's<Image>
component for optimized image handling.layout
properties (responsive
,fill
,intrinsic
) for different use cases.react/no-unescaped-entities
by escaping characters (e.g.,'
→'
).Screenshots
UI accessibility checklist
If your PR includes UI changes, please utilize this checklist:
Critical
andSerious
issues?Added/updated tests?
Please aim to keep the code coverage percentage at 80% and above.
Delete branch after merge?
What gif best describes this PR or how it makes you feel?