Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat home tab #75

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Feat home tab #75

merged 10 commits into from
Dec 13, 2024

Conversation

gurtatiLND
Copy link
Collaborator

@gurtatiLND gurtatiLND commented Dec 12, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Implemented the Home page for the application, following the design provided in Figma.
  • Added sections with SVG and image assets.
  • Replaced all <img> tags with Next.js's <Image> component for optimized image handling.
  • Configured appropriate layout properties (responsive, fill, intrinsic) for different use cases.
  • Resolved react/no-unescaped-entities by escaping characters (e.g., '&apos;).
  • Fixed accessibility and coding standard issues as per ESLint rules.
  • Fixed issues with component properties.

Screenshots

Screenshot 2024-12-12 at 14 34 47 Screenshot 2024-12-12 at 14 34 58 Screenshot 2024-12-12 at 14 35 11

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: will do it after, if needed(because this component will be refactored)
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit 083b53c
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/675c193bb77cbd0008cd4b8c
😎 Deploy Preview https://deploy-preview-75--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed my mind on this if you see it sorry, just move HomePage.tsx into a components folder in the src/app directory, rather than it being in ui/shared

@jackcasstlesjones jackcasstlesjones merged commit 663f61b into main Dec 13, 2024
5 checks passed
@jackcasstlesjones jackcasstlesjones deleted the feat-home-tab branch December 13, 2024 11:26
maxitect added a commit that referenced this pull request Dec 13, 2024
@maxitect maxitect mentioned this pull request Dec 13, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants