Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style/modal #82

Merged
merged 8 commits into from
Dec 15, 2024
Merged

Style/modal #82

merged 8 commits into from
Dec 15, 2024

Conversation

jackcasstlesjones
Copy link
Collaborator

@jackcasstlesjones jackcasstlesjones commented Dec 15, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Styling
  • Build
  • Chore

Description

  • Aesthetic changes to text inputs, input modal, needs modal

Screenshots

Screenshot 2024-12-15 at 10 38 27
Screenshot 2024-12-15 at 10 46 22
Screenshot 2024-12-15 at 10 38 33
Screenshot 2024-12-15 at 10 38 30 (2)
Screenshot 2024-12-15 at 10 38 30

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

Added/updated tests?

Please aim to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: just aesthetic changes
  • I need help with writing tests

Delete branch after merge?

  • Yes
  • No

What gif best describes this PR or how it makes you feel?

alt_text

@netlify Netlify
Copy link

netlify bot commented Dec 15, 2024 •
edited
Loading

✅ Deploy Preview for thingswedo ready!

Name Link
🔨 Latest commit d343a0f
🔍 Latest deploy log https://app.netlify.com/sites/thingswedo/deploys/675eb43904ba3e0008d6ac18
😎 Deploy Preview https://deploy-preview-82--thingswedo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

maxitect
maxitect requested changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another one! Just question around the use of focus: outline-none. See comments

src/styles/globals.css Show resolved Hide resolved
src/ui/shared/Modal.tsx Show resolved Hide resolved
src/ui/shared/Modal.tsx Show resolved Hide resolved
src/ui/shared/Modal.tsx Show resolved Hide resolved
src/ui/shared/Search.tsx Show resolved Hide resolved
maxitect
maxitect approved these changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@maxitect maxitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with that, thanks for explaining

@maxitect maxitect merged commit 50a7f54 into main Dec 15, 2024
5 checks passed
@maxitect maxitect deleted the style/modal branch December 15, 2024 11:22
maxitect added a commit that referenced this pull request Dec 16, 2024
@maxitect
chore: merge with main pr #81, #82, #83
c09577a
@maxitect maxitect mentioned this pull request Dec 16, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxitect maxitect maxitect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackcasstlesjones @maxitect