Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add tip about harmless vulnerabilities #10535

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

ilg-ul
Copy link
Contributor

@ilg-ul ilg-ul commented Sep 29, 2024

Pre-flight checklist

Motivation

Attempt to minimise support requests asking if the reported npm install vulnerabilities are harmful.

Feel free to adjust the message if necessary.

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 29, 2024
Copy link

github-actions bot commented Sep 29, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 85 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 59 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 74 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 62 🟢 96 🟢 96 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 63 🟢 96 🟢 96 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

Copy link

netlify bot commented Sep 30, 2024

[V2]

Name Link
🔨 Latest commit 992df80
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66fe6d93c982330008c7f574
😎 Deploy Preview https://deploy-preview-10535--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ilg-ul
Copy link
Contributor Author

ilg-ul commented Sep 30, 2024

Any idea what might be wrong with the failed test?

@Josh-Cena Josh-Cena changed the title docs: add a :::tip in installation.mdx to warn about harmless vulnerabilities docs: add tip about harmless vulnerabilities Sep 30, 2024
@Josh-Cena
Copy link
Collaborator

Josh-Cena commented Sep 30, 2024

No idea, but definitely not caused by this PR. I don't think I can trigger a rebuild so I'll wait for @slorber.

@slorber
Copy link
Collaborator

slorber commented Sep 30, 2024

Netlify fails randomly lately for unknown reasons. You can trigger it again with an empty commit and it should work.

@ilg-ul
Copy link
Contributor Author

ilg-ul commented Sep 30, 2024

... empty commit and it should work.

indeed.

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 3, 2024
@slorber slorber merged commit e8545b5 into facebook:main Oct 3, 2024
13 checks passed
@ilg-ul
Copy link
Contributor Author

ilg-ul commented Oct 3, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants