-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the creating of new pypi packages from github releases alone #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o code change necessary)
@PacificGilly thoughts ? this should help make the release process smoother, and allow for release notes..currently the release process is:
This should eliminate step 2 (if it works as expected) |
PacificGilly
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change idea to have a new test release per PR merge.
Co-authored-by: James Gilmore <[email protected]>
Co-authored-by: James Gilmore <[email protected]>
PacificGilly
added a commit
to PacificGilly/django-jazzmin
that referenced
this pull request
Mar 29, 2024
Since we changed our CD process and now will automatically generate test builds (farridav#550), the version in the `__init__` file now needs to be updated to stop it from being hardcoded. As in development the version is now set to 0.0.0 in the `pyproject.toml` file, we need to get the version dyanmically. We can call the package manager to check which version of `django-jazzmin` was installed. This sadly does vary depending on which version of Python is installed - support for these older versions are soon to be dropped.
PacificGilly
added a commit
to PacificGilly/django-jazzmin
that referenced
this pull request
Mar 29, 2024
Since we changed our CD process and now will automatically generate test builds (farridav#550), the version in the `__init__` file now needs to be updated to stop it from being hardcoded. As in development the version is now set to 0.0.0 in the `pyproject.toml` file, we need to get the version dyanmically. We can call the package manager to check which version of `django-jazzmin` was installed. This sadly does vary depending on which version of Python is installed - support for these older versions are soon to be dropped.
PacificGilly
added a commit
to PacificGilly/django-jazzmin
that referenced
this pull request
Mar 30, 2024
Since we changed our CD process and now will automatically generate test builds (farridav#550), the version in the `__init__` file now needs to be updated to stop it from being hardcoded. As in development the version is now set to 0.0.0 in the `pyproject.toml` file, we need to get the version dyanmically. We can call the package manager to check which version of `django-jazzmin` was installed. This sadly does vary depending on which version of Python is installed - support for these older versions are soon to be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow for us to create releases on github with zero code changes, allowing for a test, code, review, merge and release when ready from main approach
testpypi
(which i use to validate the package build and deploy works as expected) will continually bump patches on the latest published versionv
prefix removed)