Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the creating of new pypi packages from github releases alone #550

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

farridav
Copy link
Owner

This should allow for us to create releases on github with zero code changes, allowing for a test, code, review, merge and release when ready from main approach

  • testpypi (which i use to validate the package build and deploy works as expected) will continually bump patches on the latest published version
  • pypi.org will receive the version of the tag created in github (with the v prefix removed)
  • Package versions need not be tracked in the code at all

@farridav
Copy link
Owner Author

@PacificGilly thoughts ? this should help make the release process smoother, and allow for release notes..currently the release process is:

  1. change code -> merge to mainline
  2. Bump version -> merge to mainline
  3. Make release in github -> publish to pypi

This should eliminate step 2 (if it works as expected)

Copy link
Collaborator

@PacificGilly PacificGilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change idea to have a new test release per PR merge.

.github/workflows/pre-release.yml Outdated Show resolved Hide resolved
.github/workflows/pre-release.yml Outdated Show resolved Hide resolved
@farridav farridav merged commit 47f0762 into master Mar 29, 2024
5 checks passed
@farridav farridav deleted the hotfix/versions_from_releases branch March 29, 2024 14:19
PacificGilly added a commit to PacificGilly/django-jazzmin that referenced this pull request Mar 29, 2024
Since we changed our CD process and now will automatically generate test
builds (farridav#550), the version in the `__init__` file now needs to be
updated to stop it from being hardcoded. As in development the version
is now set to 0.0.0 in the `pyproject.toml` file, we need to get the
version dyanmically. We can call the package manager to check which
version of `django-jazzmin` was installed. This sadly does vary
depending on which version of Python is installed - support for these
older versions are soon to be dropped.
PacificGilly added a commit to PacificGilly/django-jazzmin that referenced this pull request Mar 29, 2024
Since we changed our CD process and now will automatically generate test
builds (farridav#550), the version in the `__init__` file now needs to be
updated to stop it from being hardcoded. As in development the version
is now set to 0.0.0 in the `pyproject.toml` file, we need to get the
version dyanmically. We can call the package manager to check which
version of `django-jazzmin` was installed. This sadly does vary
depending on which version of Python is installed - support for these
older versions are soon to be dropped.
PacificGilly added a commit to PacificGilly/django-jazzmin that referenced this pull request Mar 30, 2024
Since we changed our CD process and now will automatically generate test
builds (farridav#550), the version in the `__init__` file now needs to be
updated to stop it from being hardcoded. As in development the version
is now set to 0.0.0 in the `pyproject.toml` file, we need to get the
version dyanmically. We can call the package manager to check which
version of `django-jazzmin` was installed. This sadly does vary
depending on which version of Python is installed - support for these
older versions are soon to be dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants