Fix displaying the installed version of Django-Jazzmin in the UI. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farridav
approved these changes
Mar 29, 2024
|
3.7 is not enjoying these approaches to getting installed package versions.. |
PacificGilly
force-pushed
the
jamesgilmore/fix-version-identifier
branch
from
d46a888
to
981f36b
Compare
|
I've added |
Since we changed our CD process and now will automatically generate test builds (farridav#550), the version in the `__init__` file now needs to be updated to stop it from being hardcoded. As in development the version is now set to 0.0.0 in the `pyproject.toml` file, we need to get the version dyanmically. We can call the package manager to check which version of `django-jazzmin` was installed. This sadly does vary depending on which version of Python is installed - support for these older versions are soon to be dropped.
``` ImportError: cannot import name '_unicodefun' from 'click' ``` https://stackoverflow.com/a/71674345
In 1.3 of poetry they implemented dependency groups and so the original "dev" dependency changed from `tool.poetry.dev-dependencies` to `tool.poetry.group.dev.dependencies`.
Add a test to ensure that for every version of Python we support we're able to get the version. Not checking what that version is as that almost defeats the point of the test.
To be able to automatically get the version of the installed package of `django-jazzmin` we need to explicitly install the package as well.
PacificGilly
force-pushed
the
jamesgilmore/fix-version-identifier
branch
from
7690594
to
ed8d3ba
Compare
|
Merging as all tests pass, with only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed our CD process, and it now will automatically generate test
builds (#550), the version in the
__init__file now needs to beupdated to stop it from being hard coded. As in development, the version
is now set to 0.0.0 in the
pyproject.tomlfile; we need to get theversion dynamically. We can call the package manager to check which
version of
django-jazzminwas installed. This, sadly, does varydepending on which version of Python is installed - support for these
older versions is soon to be dropped.
In Developent
When Installed
Also a few minor fixes to
blackandpoetryin pyproject.toml I came across.