Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying the installed version of Django-Jazzmin in the UI. #555

Merged
merged 5 commits into from
Mar 30, 2024
Merged

Fix displaying the installed version of Django-Jazzmin in the UI. #555

merged 5 commits into from
Mar 30, 2024

Commits on Mar 30, 2024

  1. Fix displaying the installed version of Django-Jazzmin in the UI. 

    Since we changed our CD process and now will automatically generate test
builds (farridav#550), the version in the `__init__` file now needs to be
updated to stop it from being hardcoded. As in development the version
is now set to 0.0.0 in the `pyproject.toml` file, we need to get the
version dyanmically. We can call the package manager to check which
version of `django-jazzmin` was installed. This sadly does vary
depending on which version of Python is installed - support for these
older versions are soon to be dropped.
    @PacificGilly
    PacificGilly committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    b96d9e1 View commit details
    Browse the repository at this point in the history

  2. Upgrade black which is broken with later versions of click 

    ```
ImportError: cannot import name '_unicodefun' from 'click'
```

https://stackoverflow.com/a/71674345
    @PacificGilly
    PacificGilly committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    6652607 View commit details
    Browse the repository at this point in the history

  3. Fix poetry dependencies which changed its structure since v1.3 

    In 1.3 of poetry they implemented dependency groups and so the original
"dev" dependency changed from `tool.poetry.dev-dependencies` to
`tool.poetry.group.dev.dependencies`.
    @PacificGilly
    PacificGilly committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    865206d View commit details
    Browse the repository at this point in the history

  4. Add simple tests to validate that we're able to get the version 

    Add a test to ensure that for every version of Python we support we're
able to get the version. Not checking what that version is as that
almost defeats the point of the test.
    @PacificGilly
    PacificGilly committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    110f96e View commit details
    Browse the repository at this point in the history

  5. Add django-jazzmin to list of tox dependencies to get version 

    To be able to automatically get the version of the installed package of
`django-jazzmin` we need to explicitly install the package as well.
    @PacificGilly
    PacificGilly committed Mar 30, 2024
    Configuration menu
    Copy the full SHA
    ed8d3ba View commit details
    Browse the repository at this point in the history