Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: PID Controller (SISO) #1048

Open
2 of 11 tasks
detlefarend opened this issue Aug 31, 2024 · 1 comment · May be fixed by #1055
Open
2 of 11 tasks

BF: PID Controller (SISO) #1048

detlefarend opened this issue Aug 31, 2024 · 1 comment · May be fixed by #1055
Assignees
@amesin13
Labels
BF Basic Functions/Infrastructure enhancement New feature or request

Comments

@detlefarend
Copy link
Member

detlefarend commented Aug 31, 2024 •
edited
Loading

Description/Motivation
A classic PID controller shall be designed and implemented.

Task list

  • 1. Class design
  • 2. Implementation
    • 2.1 Class bf.control.controllers.PIDController
  • 3. Howto(s) to demonstrate the use
    • 3.1 test/howtos/bf/howto_bf_control_101_pid_controller_standalone.py
    • 3.2 test/howtos/bf/howto_bf_control_102_pid_controller_embedded.py
    • 3.3 test/howtos/bf/howto_bf_control_103_pid_controller_cascaded.py
  • 4. RTD documentation
    • 4.1 Pool object
    • 4.2 API
    • 4.3 Related howtos

Related issues
#1046 #1080

Cross references
Wikipedia: Proportional–integral–derivative controller
@detlefarend detlefarend added the enhancement New feature or request label Aug 31, 2024
This was referenced Aug 31, 2024
Closed
Open
@detlefarend
Copy link
Member Author

Hi @amesin13, the class and howto mentioned above have already been added. You can start implementing both. The howto shall demonstrate/validate the correct behavior of the pid controller on a basic level by using method compute_action directly. Further howtos shall showcase the pid controller as part of a control loop.

This was linked to pull requests Sep 1, 2024
BF/OA: Online adaptive closed-loop control #1053
Draft
BF/OA: Online adaptive PID controllers #1055
Draft
@detlefarend detlefarend removed a link to a pull request Sep 2, 2024
BF/OA: Online adaptive closed-loop control #1053
Draft
@detlefarend detlefarend added the BF Basic Functions/Infrastructure label Sep 6, 2024
amesin13 added a commit that referenced this issue Sep 10, 2024
@amesin13
BF: PID Controller (SISO) #1048
0048f8b
amesin13 added a commit that referenced this issue Sep 10, 2024
@amesin13
BF: PID Controller (SISO) #1048
a8d73f2
amesin13 added a commit that referenced this issue Oct 1, 2024
@amesin13
BF: PID Controller (SISO) #1048
ffc3d39
amesin13 added a commit that referenced this issue Oct 1, 2024
@amesin13
BF: PID Controller (SISO) #1048
4adae2f
amesin13 added a commit that referenced this issue Oct 4, 2024
@amesin13
BF: PID Controller (SISO) #1048
abc8a2b
amesin13 added a commit that referenced this issue Oct 4, 2024
@amesin13
BF: PID Controller (SISO) #1048
a1b76cb
amesin13 added a commit that referenced this issue Oct 10, 2024
@amesin13
BF: PID Controller (SISO) #1048
d699780
amesin13 added a commit that referenced this issue Oct 16, 2024
@amesin13
BF: PID Controller (SISO) #1048
9f82f20
amesin13 added a commit that referenced this issue Oct 17, 2024
@amesin13
BF: PID Controller (SISO) #1048
53dacfe
amesin13 added a commit that referenced this issue Oct 17, 2024
@amesin13
BF: PID Controller (SISO) #1048
4e08002
amesin13 added a commit that referenced this issue Oct 17, 2024
@amesin13
BF: PID Controller (SISO) #1048
f88552d
amesin13 added a commit that referenced this issue Oct 17, 2024
@amesin13
BF: PID Controller (SISO) #1048
380242f
amesin13 added a commit that referenced this issue Oct 17, 2024
@amesin13
BF: PID Controller (SISO) #1048
742fe12
amesin13 added a commit that referenced this issue Oct 21, 2024
@amesin13
BF: PID Controller (SISO) #1048
a45564c
amesin13 added a commit that referenced this issue Oct 28, 2024
@amesin13
BF: PID Controller (SISO) #1048
d147dd2
amesin13 added a commit that referenced this issue Oct 28, 2024
@amesin13
BF: PID Controller (SISO) #1048
63788c7
amesin13 added a commit that referenced this issue Nov 10, 2024
@amesin13
BF: PID Controller (SISO) #1048
f35cf28
amesin13 added a commit that referenced this issue Nov 25, 2024
@amesin13
BF: PID Controller (SISO) #1048
8839737
amesin13 added a commit that referenced this issue Dec 5, 2024
@amesin13
BF: PID Controller (SISO) #1048
f01c19a
amesin13 added a commit that referenced this issue Jan 6, 2025
@amesin13
BF: PID Controller (SISO) #1048
9f7960f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amesin13 amesin13

Labels
BF Basic Functions/Infrastructure enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BF/OA: Online adaptive PID controllers fhswf/MLPro
2 participants
@detlefarend @amesin13