-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip changelog] feat(f3): override F3BootstrapEpoch on 2k devnet with environment variable #12354
[skip changelog] feat(f3): override F3BootstrapEpoch on 2k devnet with environment variable #12354
Conversation
It seems like this check is failing due to GitHub's security restrictions on Actions running on PRs from forks. I will adjust the workflow accordingly today, so that we can land this with a completely green CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
5b2d660
to
ec3842e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
PR title now matches the required format.
I looked at the failing "PR Title Check" despite conforming to our conventions. The issue stems from the recent change in our workflow to allow running on PRs from forks:
It's safe to ignore the failing check from the obsolete workflow. Apologies for the confusion and noise in your PR. |
Related Issues
Proposed Changes
To facilitate local and CI testing for F3 on forest side, this PR adds environment variables to override
F3Enabled
andF3BootstrapEpcoh
on 2k devnet. (just like how network upgrade epochs can be overridden with environment variables)(Skipping changelog as similar
LOTUS_{NETWORK}_HEIGHT
changes do not present in CHANGELOG.md)Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps[skip changelog]
to the PR titleskip/changelog
to the PR