Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): support checking forks in PR-title check workflow #12367

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Aug 9, 2024

Related Issues

Encountered this workflow-failure when looking at merging: #12354 (comment)

Proposed Changes

  • Use pull_request_target event trigger in pr-title-check-yml in order to support checking PRs from forks.

Additional Info

Creating this PR from my Lotus-fork to confirm that it now succeeds

Checklist

Before you mark the PR ready for review, please make sure that:

Use `pull_request_target` event trigger in order to support checking PRs from forks.
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Aug 9, 2024
@rjan90 rjan90 requested a review from aarshkshah1992 August 9, 2024 13:41
@rjan90 rjan90 merged commit a359f84 into filecoin-project:master Aug 9, 2024
81 checks passed
@rjan90 rjan90 deleted the rjan-support-PR-check-forks branch August 9, 2024 16:44
@BigLep
Copy link
Member

BigLep commented Aug 9, 2024

@rjan90 : I did some more research here as well, and it looks like this addresses the problem you saw in #12354 (comment) . I may have gotten confused from our call - what is leading you to think this doesn't/won't work? (If things are working, feel free to disregard.)

One nit is that I think we can drop the synchronize type since that is for when commits have been pushed which I think is separate than PR titles.

rjan90 added a commit to hanabi1224/lotus that referenced this pull request Aug 12, 2024
…-project#12367)

Use `pull_request_target` event trigger in order to support checking PRs from forks.
rjan90 added a commit that referenced this pull request Aug 12, 2024
Use `pull_request_target` event trigger in order to support checking PRs from forks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants