-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eth): refactor eth API module into separate pieces in new pkg #12796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/ethmodule-refactor
branch
2 times, most recently
from
December 19, 2024 08:39
889a696
to
0d22219
Compare
Stebalien
reviewed
Dec 20, 2024
Stebalien
reviewed
Dec 20, 2024
Stebalien
approved these changes
Dec 20, 2024
Additional fixes applied after a sync zoom chat with @Stebalien about this:
|
rvagg
force-pushed
the
rvagg/ethmodule-refactor
branch
from
December 20, 2024 08:25
8998024
to
27a1b51
Compare
rvagg
removed
the
skip/changelog
This change does not require CHANGELOG.md update
label
Dec 20, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I start on the
/v2
API the eth module is my first hurdle: I was/v1
to remain as it is now, but/v2
to have the same Eth endpoints but be F3 aware, so"finalized"
and"safe"
get adjusted according to F3. Otherwise they should be the same. Because almost everything is in a single eth.go, it makes it a bit hard to do a nice pluggable solution where I can reuse most of the code and just have replacements for a resolver. So I decided to rip apart the eth.go monolith into smaller components, in their own package, with interfaces for their dependencies rather than the concrete types.There's very little change in the code even though the diff is big, it's mostly just moving things around. I took a few opportunities to clean up some awkward messes, and I was forced to do some new mildly awkward new things.
github.com/filecoin-project/lotus/node/impl/eth
is a new package, with what used to be ingithub.com/filecoin-project/lotus/node/impl/full/eth*.go
but logically split up.ChainStore
andStateManager
.github.com/filecoin-project/lotus/node/impl/gasutils
contains some components that were innode/impl/full/gas.go
but are shared between Filecoin and Eth APIs.xerrors
in the new eth package.