-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List inputs in lda encode/decode, and clip text_encoder. #213
Conversation
In current code The naming for helpers would be WDYT ? |
Not sure using plural will mean the same depending on the reader (e.g. latents -> latent variables vs. sequence of latent vectors). Perhaps we could make our life simpler and just adopt "latents" systematically (seems pretty widespread already: "CLIP latents", etc). @limiteinductive any strong preference on your end? |
It's almost a convention that "latent" is always plural. Since a Tensor is a batch, you can have a single Tensor is still have multiple "latents." |
Thanks for your help @deltheil @limiteinductive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only minor feedback, please take a look
@piercus do you mind rebasing this branch onto |
51544cb
to
21d3a23
Compare
Squash and merge done |
* text_encoder([str1, str2]) * lda decode_latents/encode_image image_to_latent/latent_to_image * images_to_tensor, tensor_to_images --------- Co-authored-by: Cédric Deltheil <[email protected]>
21d3a23
to
a4014f1
Compare
`encode_image` has been deprecated part of #213
`encode_image` has been deprecated part of #213
`encode_image` has been deprecated part of #213
Naming of
lda.decode_latents(latents)
feels strange causelda.decode(latents)
is also decoding latents.I suggest using
lda.decode_image
/lda.decode_images
andlda.encode_image
/lda.encode_images
To not break examples, the current PR is keeping an alias
lda.decode_latents(latents) -> lda.decode_image(latents)