Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Changes: v3.0.0 #111

Merged
merged 53 commits into from
Jul 18, 2023
Merged

Breaking Changes: v3.0.0 #111

merged 53 commits into from
Jul 18, 2023

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Jul 15, 2023 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using "x"

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • ..... (describe the other type)

What is the current behavior?

Issue Number: #87

What is the new behavior?

See the inner PR: #108 #109 #110 #112 #114 #116 #117

Other information

This PR will resolve #87

@fityannugroho
chore: update tsconfig and nest-cli config
0769de9 
- change ts compiler target to ES2021
- set nest-cli deleteOutDir option
@fityannugroho
refactor: add path alias to src & move PrismaService to separate module
fef9de0 
- Add `@/` as path alias to `src` folder
- Create `PrismaModule` that export the `PrismaService`
@fityannugroho
refactor: move config folder into src/common
a7110e7
@fityannugroho
refactor: move AppTester into test/helper
bd3d76f
@fityannugroho
refactor: move utils to src\common\utils
d2ebeca
@fityannugroho
refactor: convert Sorter into SortService
64dc6c3
@fityannugroho
refactor: move CoordinateConverter into src/common/utils
496ac92
@fityannugroho
chore: remove ~/ ts path alias
f96559d
@fityannugroho
build(deps): upgrade to prisma 5
b7a8320 
- Upgrade `prisma` to v5.0.0
- Upgrade `@prisma/client` to v5.0.0
- Set minimum node version to 18.0.0
@fityannugroho
fix: remove unused beforeExit hook from PrismaService
fac34df
@fityannugroho
chore(swc): add jsc.paths config
d23f849
@fityannugroho
Merge branch 'refactor-dir' into upgrade-prisma
6a27635
@fityannugroho
build(deps): set minimum node to v18
2b9130a
@fityannugroho
Merge pull request #108 from fityannugroho/refactor-dir
f15f20f 
Refactor the directory structure
@fityannugroho
ci(tests): remove testing for node 16.x
6f21b13
@fityannugroho
Merge pull request #109 from fityannugroho/upgrade-prisma
2506462 
Upgrade to Prisma 5 & Node.js 18
@fityannugroho
chore: fix paths config
b8a0ddc 
- Remove baseUrl and paths from swcrc, it will be auto-populated from the tsconfig.json by nest-cli
- Update moduleNameMapper in jest configs
@fityannugroho
refactor(test): use Promise.all & use expectBadCode directly
924b3a1
@fityannugroho
build(deps): uninstall jest, install and configure vitest
ecfdabe
@fityannugroho
Merge pull request #110 from fityannugroho/improve-test
bf98835 
Improve test
@fityannugroho fityannugroho added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 15, 2023
@fityannugroho
build(deps): upgrade linter
f0878e2 
- `prettier` to v3.0.0
- `eslint-plugin-prettier` to v5.0.0
- `@typescript-eslint/eslint-plugin` to v6.0.0
- `@typescript-eslint/parser` to v6.0.0
@fityannugroho
style: format code with updated linter
d5b104c
@fityannugroho
Merge pull request #112 from fityannugroho/upgrade-linter
81ff9ae 
Upgrade linter
@fityannugroho
feat: update SortOption and SortQuery generic param
dda0509 
- Change generic param from string literal into Record
- Make `sortBy` and `sortOrder` read only
@fityannugroho
feat(common): init CommonService
872d272
@fityannugroho
feat(province): improve service & controller
325c470
@fityannugroho
feat(regency): improve service & controller
d4f90b2
@fityannugroho
feat(district): improve service & controller
7e5f7b0
@fityannugroho
feat(village): improve service & controller
ba96ae0
@fityannugroho
feat(island): improve service & controller
8c30068
@fityannugroho
fix(province): sort options for regencies
8104ec6
@fityannugroho
fix(district): sort options for villages
0fe4815
@fityannugroho
fix(regency): sort options for district
6fe672d
@fityannugroho
fix(common): add sorter property
7e8285c
@fityannugroho
feat: forbid unknown request params/queries
55c5adc
@fityannugroho
Merge pull request #114 from fityannugroho/improve-code
d894620 
Improve sorting and validation
@fityannugroho
test: add all missing module imports
76604ed
@fityannugroho
test(province): add ProvinceController tests suite
4fb8bd5
@fityannugroho
refactor(regency): fix typo in method name & set query param to optional
f63c2b4
@fityannugroho
test(regency): add RegencyController tests suite
6fdc013
@fityannugroho
test(province): update ProvinceController tests suite
8c35040
@fityannugroho
test(regency): fix data source
34198a8
@fityannugroho
test(district): add DistrictController tests suite
31d8a0d
@fityannugroho
test(island): add IslandController tests suite
433e430
@fityannugroho
test(village): add VillageController tests suite
fb99734
@fityannugroho
test(province,regency,district,island,village): simplify tests suite
50665d6
@fityannugroho
test(province,regency,district,island,village): delete services tests
df8cfe9
@fityannugroho
Merge pull request #116 from fityannugroho/fix-test
212f7e6 
Fix unit tests
@fityannugroho
build(deps): patch and minor upgrade
2be2cd4
@fityannugroho
Merge pull request #117 from fityannugroho/update-deps
8eb8180 
build(deps): patch and minor upgrade
@fityannugroho
3.0.0
8841a06
@fityannugroho
docs: update readme and installation guide
b8e2978
@fityannugroho
build(deps): bump idn-area-data to 2.1.2
e4d48a3
@fityannugroho fityannugroho merged commit b00846a into main Jul 18, 2023
4 checks passed
@fityannugroho fityannugroho deleted the upgrade-v3.0.0 branch July 18, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SUGGEST] Speed up testing
1 participant
@fityannugroho