Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Changes: v3.0.0 #111

Merged
merged 53 commits into from
Jul 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
0769de9
chore: update tsconfig and nest-cli config
fityannugroho Jul 14, 2023
fef9de0
refactor: add path alias to src & move PrismaService to separate module
fityannugroho Jul 14, 2023
a7110e7
refactor: move `config` folder into `src/common`
fityannugroho Jul 14, 2023
bd3d76f
refactor: move `AppTester` into `test/helper`
fityannugroho Jul 14, 2023
d2ebeca
refactor: move utils to `src\common\utils`
fityannugroho Jul 14, 2023
64dc6c3
refactor: convert Sorter into SortService
fityannugroho Jul 14, 2023
496ac92
refactor: move CoordinateConverter into `src/common/utils`
fityannugroho Jul 14, 2023
f96559d
chore: remove `~/` ts path alias
fityannugroho Jul 14, 2023
b7a8320
build(deps): upgrade to prisma 5
fityannugroho Jul 14, 2023
fac34df
fix: remove unused beforeExit hook from PrismaService
fityannugroho Jul 14, 2023
d23f849
chore(swc): add jsc.paths config
fityannugroho Jul 14, 2023
6a27635
Merge branch 'refactor-dir' into upgrade-prisma
fityannugroho Jul 14, 2023
2b9130a
build(deps): set minimum node to v18
fityannugroho Jul 14, 2023
f15f20f
Merge pull request #108 from fityannugroho/refactor-dir
fityannugroho Jul 14, 2023
6f21b13
ci(tests): remove testing for node 16.x
fityannugroho Jul 14, 2023
2506462
Merge pull request #109 from fityannugroho/upgrade-prisma
fityannugroho Jul 15, 2023
b8a0ddc
chore: fix paths config
fityannugroho Jul 15, 2023
924b3a1
refactor(test): use Promise.all & use expectBadCode directly
fityannugroho Jul 15, 2023
ecfdabe
build(deps): uninstall jest, install and configure vitest
fityannugroho Jul 15, 2023
bf98835
Merge pull request #110 from fityannugroho/improve-test
fityannugroho Jul 15, 2023
f0878e2
build(deps): upgrade linter
fityannugroho Jul 15, 2023
d5b104c
style: format code with updated linter
fityannugroho Jul 15, 2023
81ff9ae
Merge pull request #112 from fityannugroho/upgrade-linter
fityannugroho Jul 15, 2023
dda0509
feat: update SortOption and SortQuery generic param
fityannugroho Jul 16, 2023
872d272
feat(common): init CommonService
fityannugroho Jul 16, 2023
325c470
feat(province): improve service & controller
fityannugroho Jul 16, 2023
d4f90b2
feat(regency): improve service & controller
fityannugroho Jul 16, 2023
7e5f7b0
feat(district): improve service & controller
fityannugroho Jul 16, 2023
ba96ae0
feat(village): improve service & controller
fityannugroho Jul 16, 2023
8c30068
feat(island): improve service & controller
fityannugroho Jul 17, 2023
8104ec6
fix(province): sort options for regencies
fityannugroho Jul 17, 2023
0fe4815
fix(district): sort options for villages
fityannugroho Jul 17, 2023
6fe672d
fix(regency): sort options for district
fityannugroho Jul 17, 2023
7e8285c
fix(common): add sorter property
fityannugroho Jul 17, 2023
55c5adc
feat: forbid unknown request params/queries
fityannugroho Jul 17, 2023
d894620
Merge pull request #114 from fityannugroho/improve-code
fityannugroho Jul 17, 2023
76604ed
test: add all missing module imports
fityannugroho Jul 17, 2023
4fb8bd5
test(province): add ProvinceController tests suite
fityannugroho Jul 17, 2023
f63c2b4
refactor(regency): fix typo in method name & set query param to optional
fityannugroho Jul 17, 2023
6fdc013
test(regency): add RegencyController tests suite
fityannugroho Jul 17, 2023
8c35040
test(province): update ProvinceController tests suite
fityannugroho Jul 17, 2023
34198a8
test(regency): fix data source
fityannugroho Jul 17, 2023
31d8a0d
test(district): add DistrictController tests suite
fityannugroho Jul 18, 2023
433e430
test(island): add IslandController tests suite
fityannugroho Jul 18, 2023
fb99734
test(village): add VillageController tests suite
fityannugroho Jul 18, 2023
50665d6
test(province,regency,district,island,village): simplify tests suite
fityannugroho Jul 18, 2023
df8cfe9
test(province,regency,district,island,village): delete services tests
fityannugroho Jul 18, 2023
212f7e6
Merge pull request #116 from fityannugroho/fix-test
fityannugroho Jul 18, 2023
2be2cd4
build(deps): patch and minor upgrade
fityannugroho Jul 18, 2023
8eb8180
Merge pull request #117 from fityannugroho/update-deps
fityannugroho Jul 18, 2023
8841a06
3.0.0
fityannugroho Jul 18, 2023
b8e2978
docs: update readme and installation guide
fityannugroho Jul 18, 2023
e4d48a3
build(deps): bump idn-area-data to 2.1.2
fityannugroho Jul 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ module.exports = {
plugins: ['@typescript-eslint/eslint-plugin'],
extends: [
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/stylistic',
'plugin:prettier/recommended',
],
root: true,
env: {
node: true,
jest: true,
},
ignorePatterns: ['.eslintrc.js'],
rules: {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
max-parallel: 1
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases

steps:
Expand Down
3 changes: 1 addition & 2 deletions .swcrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"transform": {
"legacyDecorator": true,
"decoratorMetadata": true
},
"baseUrl": "./"
}
},
"minify": false
}
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ API that provides information on the **administrative areas of Indonesia**, from

Built with [NestJS framework](https://nestjs.com) and writen in TypeScript. [Prisma](https://www.prisma.io) is used as the ORM to interact with any kind of database.

> **NEW!** **PostgreSQL and MySQL** is supported since version 2.0.0. See the [installation guide](docs/installation.md).
> **⚠️ Upgrading to v3.0.0 ⚠️**
>
> Since v3.0.0, **Node.js v18** or higher is required. See the [installation guide](docs/installation.md).

<h2>Table of Content</h2>

Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

## Prerequisite

- [Node.js](https://nodejs.org/en) (version 16 or higher)
- [Node.js](https://nodejs.org/en) (version 18 or higher)
- [npm](https://www.npmjs.com)
- Database provider you want to use. We currently support MongoDB, PostgreSQL, and MySQL. See supported databases version [here](https://www.prisma.io/docs/reference/database-reference/supported-databases).

Expand Down
22 changes: 0 additions & 22 deletions jest.config.json

This file was deleted.

6 changes: 5 additions & 1 deletion nest-cli.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
{
"$schema": "https://json.schemastore.org/nest-cli",
"collection": "@nestjs/schematics",
"sourceRoot": "src"
"sourceRoot": "src",
"compilerOptions": {
"deleteOutDir": true
}
}
Loading
Loading