Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no SMS & Whatsapp double signup validation #15

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

jonathansberry
Copy link
Member

@jonathansberry jonathansberry commented Jan 8, 2025

Description

As requested by the client, ensures no users can sign up to both SMS and Whatsapp notifications.

Checklist

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request).
You may not need to check all boxes.

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

@jonathansberry jonathansberry changed the title Feat no SMS & Whatsapp signup validation feat: no SMS & Whatsapp double signup validation Jan 8, 2025
@jonathansberry jonathansberry merged commit 410936d into master Jan 8, 2025
2 checks passed
@jonathansberry jonathansberry deleted the feat-sms-whatsapp-signup-validation branch January 8, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant