hint text in stan editor #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
approved these changes
Jul 25, 2024
Comment on lines
249
to
252
| node.style.width = "max-content"; | ||
| node.style.pointerEvents = "none"; | ||
| node.textContent = hintText; | ||
| node.style.fontStyle = "italic"; |
There was a problem hiding this comment.
Thoughts on pulling these .styles into a class? In particular, it would also be nice to make the text slightly lower contrast than it is currently, as vscode does
There was a problem hiding this comment.
I have created a css class EditorHintText for the italics and color. I feel like pointerEvents still belongs inline though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If stan editor is empty, display hint message in the editor "Begin editing or select an example from the left panel" using monaco's addContentWidget.
And... no longer abuses syntax error window for this purpose.
See discussion in #149