Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "update the repo references for package:file (#55906)" #55916

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Oct 16, 2024

Reverts: #55906

Initiated by: zanderso

Reason for reverting: b/373907578

Original PR Author: devoncarew

Reviewed By: {zanderso}

This change reverts the following previous change:
The SoT repository for package:file has changed from google/file.dart to dart-lang/tools; this PR updates the DEPS file and the hard-coded paths in the two pubspec.yaml files.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Oct 16, 2024
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Oct 16, 2024
@auto-submit auto-submit bot merged commit f12e0d3 into main Oct 16, 2024
6 of 7 checks passed
@auto-submit auto-submit bot deleted the revert_066a3c71187bb3b6ef694decb9c32287bcd06e45 branch October 16, 2024 21:46
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 17, 2024
…ions) (#157066)

Manual roll requested by [email protected]

Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE

2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (#55906)" (flutter/engine#55916)
2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (#55884)" (flutter/engine#55915)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (#55896)" (flutter/engine#55914)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (#55903)" (flutter/engine#55913)
2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906)
2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740)
2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Lurchfresser pushed a commit to Lurchfresser/flutter that referenced this pull request Oct 17, 2024
…ions) (flutter#157066)

Manual roll requested by [email protected]

Cannot build log URL because revision "f12e0d385f4d" is invalid: Luci builds of "Linux Web Framework tests" for f12e0d385f4d64765ed46c7c3ac8fa7fa8bc3c43 was FAILURE

2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "update the repo references for package:file (flutter#55906)" (flutter/engine#55916)
2024-10-16 [email protected] Roll Skia from 09917e06158b to 3a081993e2a7 (3 revisions) (flutter/engine#55911)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 2bf0f2b8d391 (24 revisions) (flutter#55884)" (flutter/engine#55915)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 2bf0f2b8d391 to 7fce3544047c (4 revisions) (flutter#55896)" (flutter/engine#55914)
2024-10-16 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from 7fce3544047c to 148b7c530657 (3 revisions) (flutter#55903)" (flutter/engine#55913)
2024-10-16 [email protected] update the repo references for package:file (flutter/engine#55906)
2024-10-16 [email protected] Handle out-of-order add/remove pointer events (flutter/engine#55740)
2024-10-16 [email protected] Starts looking for the bdf fast path in relation to the snapshot_entity's transform (flutter/engine#55890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
devoncarew added a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants