Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve screenshot cmd #519

Merged

Conversation

ExampleWasTaken
Copy link
Contributor

Description

This is a very minor improvement to the .screenshot command (better known as .ss). It adds an explanation for why a screenshot is necessary.


While at it, I also changed some other minor things:

Motivation

At the moment, just sending the command in response to a support request may come across a bit condescending as the user's issue is not acknowledged. For this reason, I often find myself (and others) using the command and appending the reason for it to my message. The reason always being the same, I think it would be beneficial to have it included in the embed.

Test Results

Before After
image image

Discord Username

examplewastaken

Copy link
Collaborator

@pdellaert pdellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but you would need to create a CHANGELOG entry

@pdellaert pdellaert merged commit 3cab9a1 into flybywiresim:staging May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants