Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of quality of service #5963

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

fix old nil pointer bug

8a2b430
Select commit
Loading
Failed to load commit list.
Open

Improve test coverage of quality of service #5963

fix old nil pointer bug
8a2b430
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 9, 2024 in 1s

50.86% (+14.05%) compared to 636cc23

View this Pull Request on Codecov

50.86% (+14.05%) compared to 636cc23

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.86%. Comparing base (636cc23) to head (8a2b430).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
.../pkg/manager/impl/executions/quality_of_service.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5963       +/-   ##
===========================================
+ Coverage   36.81%   50.86%   +14.05%     
===========================================
  Files        1310     1164      -146     
  Lines      131034    89475    -41559     
===========================================
- Hits        48237    45512     -2725     
+ Misses      78611    39956    -38655     
+ Partials     4186     4007      -179     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.