Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of quality of service #5963

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

fix old nil pointer bug

8a2b430
Select commit
Loading
Failed to load commit list.
Open

Improve test coverage of quality of service #5963

fix old nil pointer bug
8a2b430
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 9, 2024 in 1s

75.00% of diff hit (target 36.81%)

View this Pull Request on Codecov

75.00% of diff hit (target 36.81%)

Annotations

Check warning on line 166 in flyteadmin/pkg/manager/impl/executions/quality_of_service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteadmin/pkg/manager/impl/executions/quality_of_service.go#L166 

Added line #L166 was not covered by tests
View more details on Codecov