Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added examples for tensorflow types in Datatypes and IO section #1739

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Added examples for tensorflow types in Datatypes and IO section #1739

merged 7 commits into from
Oct 17, 2024

Conversation

sumana-2705
Copy link
Contributor

@sumana-2705 sumana-2705 commented Oct 4, 2024 •
edited
Loading

I have added a tensorflow_tpe.py file in Data Types and IO section, explaining Tensorflow types supported by Flyte with their example usage and workflow.

@davidmirror-ops davidmirror-ops self-requested a review October 4, 2024 20:57
@davidmirror-ops
Copy link
Contributor

@neverett similar question here around the failing monodocs test
@sumana-2705 could you check the linting errors? Thanks

@neverett
Copy link
Contributor

neverett commented Oct 7, 2024

@davidmirror-ops this content wasn't moved, and it looks like the readthedocs test is passing, and other tests are awaiting approval. There may have been a transient failure due to the DocSearch API key not being available, which was fixed last Friday.

@sumana-2705
Copy link
Contributor Author

@davidmirror-ops
I have fixed the format of the code, which was causing linting errors. can you please review it again. 🙏
Thank you.

@davidmirror-ops
Copy link
Contributor

@sumana-2705 thanks for your perseverance. The single failing test points to the fact that the default base image used in the examples doesn't include tensorflow.
Please take a look at how this example defines a custom image using ImageSpec which contains tensorflow.

@sumana-2705
Copy link
Contributor Author

@neverett @davidmirror-ops
I have updated the branch, Is this PR ready to merge now?

@davidmirror-ops davidmirror-ops merged commit f12e916 into flyteorg:master Oct 17, 2024
7 checks passed
@eapolinario eapolinario mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neverett neverett neverett approved these changes

@ppiegaze ppiegaze Awaiting requested review from ppiegaze ppiegaze is a code owner

@davidmirror-ops davidmirror-ops Awaiting requested review from davidmirror-ops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sumana-2705 @davidmirror-ops @neverett