Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINVSTOR-1342: Add "deleted" field to Instance schema #1146

Merged
merged 6 commits into from
Feb 12, 2025
Merged

MODINVSTOR-1342: Add "deleted" field to Instance schema #1146

merged 6 commits into from
Feb 12, 2025

Conversation

AndreiBordak
Copy link
Contributor

@AndreiBordak AndreiBordak commented Feb 6, 2025 •
edited
Loading

Purpose

Add "deleted" field to Instance schema

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

List any Jira issues related to this pull request.

@AndreiBordak AndreiBordak requested a review from a team as a code owner February 6, 2025 10:55
@AndreiBordak AndreiBordak changed the title Modinvstor 1342 MODINVSTOR-1342: Add "deleted" field to Instance schema Feb 6, 2025
pkjacob
pkjacob reviewed Feb 6, 2025
View reviewed changes
NEWS.md Outdated
@@ -1,6 +1,6 @@
## v28.1.0 YYYY-mm-DD
### Breaking changes
* Description ([ISSUE](https://folio-org.atlassian.net/browse/ISSUE))
* Add "deleted" field to Instance schema ([MODINVSTOR-1342](https://folio-org.atlassian.net/browse/MODINVSTOR-1342))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is a breaking change. Add this under a heading ### Features?

@pkjacob
Copy link

pkjacob commented Feb 6, 2025

@AndreiBordak Jenkins build has failed

@AndreiBordak
Copy link
Contributor Author

@AndreiBordak Jenkins build has failed

image image

tests that failed on Jenkins are green on local env, let me double-check later

psmagin
psmagin requested changes Feb 10, 2025
View reviewed changes
ramls/instance.json Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mariia-aloshyna mariia-aloshyna mentioned this pull request Feb 12, 2025
Merged
@psmagin psmagin merged commit 8225f3e into master Feb 12, 2025
5 of 6 checks passed
@psmagin psmagin deleted the MODINVSTOR-1342 branch February 12, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkjacob pkjacob pkjacob left review comments

@psmagin psmagin psmagin approved these changes

@viacheslavkol viacheslavkol viacheslavkol approved these changes

@SvitlanaKovalova1 SvitlanaKovalova1 SvitlanaKovalova1 approved these changes

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@KaterynaSenchenko KaterynaSenchenko Awaiting requested review from KaterynaSenchenko

@PBobylev PBobylev Awaiting requested review from PBobylev

@askhat-abishev askhat-abishev Awaiting requested review from askhat-abishev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndreiBordak @pkjacob @psmagin @viacheslavkol @SvitlanaKovalova1