Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3191: Add new ‘Set for deletion’ flag to display on 3rd pane Instance view #2742

Merged
merged 9 commits into from
Feb 14, 2025

Conversation

mariia-aloshyna
Copy link
Contributor

@mariia-aloshyna mariia-aloshyna commented Feb 12, 2025

Should be merged together with folio-org/mod-inventory-storage#1146

Purpose

When ‘Set for deletion’ flag is invoked, a warning message should display at the top of the 3rd pane Instance view.

Approach

  • Moved warning banner conditions and translation IDs to a variable
  • Added a new warning banner in case an instance was set for deletion, staff and discovery suppressed
  • Added a new Set for deletion flag in case an instance was set for deletion
  • Covered with unit tests

Refs

UIIN-3191

Screenshots

Screenshot 2025-02-12 at 14 02 31

Copy link

github-actions bot commented Feb 12, 2025

Jest Unit Test Results

    1 files  ±0    256 suites  ±0   10m 59s ⏱️ -20s
1 035 tests +1  1 033 ✅ +1  2 💤 ±0  0 ❌ ±0 
1 042 runs  +1  1 040 ✅ +1  2 💤 ±0  0 ❌ ±0 

Results for commit 4c0a791. ± Comparison against base commit 04fcc5d.

♻️ This comment has been updated with latest results.

@mariia-aloshyna mariia-aloshyna merged commit 48dbf01 into master Feb 14, 2025
15 checks passed
@mariia-aloshyna mariia-aloshyna deleted the UIIN-3191 branch February 14, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants