Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .lst file creation directives #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icypawn
Copy link

@icypawn icypawn commented Feb 28, 2019

  • -u
  • -U
   -L         Create verbose listing (expand REPT, MACRO)

-u will only expand macros (rept definitions are shown)... reduces .lst file size

 (without -U directive, -u keeps macro definitions shown)

-U will ONLY expand macro use; hides macro definitions and also runs -u flag


line 1687 is major change that runs listline depending on 5 flags

that line is simplified with boolean algebra :)

Note: running asm6f with all the listing flags will cause a -L lst file to be created, like Loopy's original design :)

  all lines we edited end with 0_0
		except: the 4 variables we created at the end of the variable list
				and line 1687... sorry.

  we is God, my heavenly father, and me :)

p.s. Koitsu encouraged me to submit these changes to your asm6f

@icypawn icypawn force-pushed the adding-lst-creation-options branch from e991c80 to ebde657 Compare March 2, 2019 19:05
	* -u
	* -U
-u will cause lst file to only display rept definitions... reduces .lst file size ie .rept 256
-U will expand ONLY macro use... hiding macro definitions and also runs -u flag

line 1687 is major change that runs listline depending on 5 flags
	that line is simplified with boolean algebra :)

This ammend changes line 1769's | to a +.  Believe this will eliminate all "possible" failures. :)

Note: running asm6f with all the listing flags will cause a -L lst file to be created, like Loopy's original design :)

	  all lines we edited end with 0_0
			except: the 4 variables we created at the end of the variable list
					and line 1687... sorry.

	  we is God, my heavenly father, and me :)
@icypawn icypawn force-pushed the adding-lst-creation-options branch from ebde657 to c69f34a Compare March 2, 2019 19:20
@icypawn
Copy link
Author

icypawn commented Mar 2, 2019

YEAY, branch c69f34a has the change from line 1769... that line's | was changed to a + because that should eliminate all of the "possible" problems that may happen if insidemacro and insiderept are ever both nonzero.

I learned to always close the file before pushing something. And to never change anything because that will eliminate all comments. :(

branch ebde657 is pointless... I hadn't closed the asm6f.c so it didn't update.

My comments that got eliminated said something like:
Line 1687 is the heart of my changes. And... I can't remember right now.
final edit: those eliminated comments have been rewritten on branch c69f34a

@freem freem self-assigned this Mar 20, 2019
@icypawn
Copy link
Author

icypawn commented Apr 2, 2019

freem, is there something else I need to do? I'm done with editing this commit. :)

@@ -1871,6 +1881,13 @@ int main(int argc,char **argv) {
case 'f':
genlua=1;
break;
// [unregistered addition]
case 'U':
vacillatemacro=1;
Copy link
Owner

@freem freem Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the fallthrough here intentional? (Or in other words, -u and -U are mostly similar, but -u doesn't set vacillatemacro)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the fallthrough on case U is intentional. (Just like loopy's -L -l fallthrough is intentional.) That's where that fallthrough idea came from; furthermore, the fallthrough on -U reduced the boolean algebra result on 1687. It is simpler and takes less lines of code. :) Both beneficial, for me at least. :)

Copy link
Author

@icypawn icypawn Apr 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's intentional. :) Both -u and -U set needrept to 0 and set listfilename to true_ptr (if listfilename==true_ptr then asm6 creates a listing file... listfilename=true_ptr is also underneath -L and -l; after thinking about this for quite a while, it doesn't seem possible to conveniently have -L, -l, -U, and -u to use the same listfilename=true_ptr). However, -U also sets vacillatemacro to 1. The state of the flags needrept and vacillatemacro help the program to know how to branch after loading them in other places in this commit's code. I have a page of boolean algebra that verifies what you encounter when you run this commit. It does work freem.

The simplicity is purposeful. Personally, I didn't want to cause the user's computer to have to do an extensive amount of work compared to asm6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants