-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added .lst file creation directives #24
Open
icypawn
wants to merge
1
commit into
freem:master
Choose a base branch
from
icypawn:adding-lst-creation-options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fallthrough here intentional? (Or in other words,
-u
and-U
are mostly similar, but-u
doesn't setvacillatemacro
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the fallthrough on case U is intentional. (Just like loopy's -L -l fallthrough is intentional.) That's where that fallthrough idea came from; furthermore, the fallthrough on -U reduced the boolean algebra result on 1687. It is simpler and takes less lines of code. :) Both beneficial, for me at least. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's intentional. :) Both
-u
and-U
setneedrept
to 0 and setlistfilename
totrue_ptr
(iflistfilename
==true_ptr
then asm6 creates a listing file...listfilename=true_ptr
is also underneath-L
and-l
; after thinking about this for quite a while, it doesn't seem possible to conveniently have-L
,-l
,-U
, and-u
to use the samelistfilename=true_ptr
). However,-U
also setsvacillatemacro
to 1. The state of the flagsneedrept
andvacillatemacro
help the program to know how to branch after loading them in other places in this commit's code. I have a page of boolean algebra that verifies what you encounter when you run this commit. It does work freem.The simplicity is purposeful. Personally, I didn't want to cause the user's computer to have to do an extensive amount of work compared to asm6.