New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ipv4 function return value #5

Merged

frenchbread merged 2 commits into frenchbread:master from vasco-santos:fix/ipv4-function-return-value

Nov 29, 2020

Contributor

vasco-santos commented Nov 28, 2020 •

edited

Loading

Fixes #4 (comment)

cc @frenchbread


          fix: ipv4 function return value

886443d

Owner

frenchbread commented Nov 28, 2020

Thanks for quick fix!

How about also renaming netmaskCheck into smth like ipv4Check so it's more consistent? 😃


          chore: rename ipv4 check function

12fe854

Contributor Author

vasco-santos commented Nov 29, 2020

@frenchbread fixed

Owner

frenchbread commented Nov 29, 2020

@vasco-santos thanks, looks good!

frenchbread merged commit 59fde62 into frenchbread:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet