Fix sonarcloud #39

fschuch · 2024-05-15T21:59:57Z

No description provided.

coderabbitai · 2024-05-15T22:00:04Z

Walkthrough

The recent updates focus on enhancing the CI workflow by dynamically setting project versions from Git tags, improving test job resilience, ensuring macOS compatibility, configuring Sonar analysis, and specifying Python versions for better coverage and source management.

Changes

File	Change Summary
`.github/workflows/ci.yaml`	Updated `TAG_NAME` extraction, `sonar.projectVersion`, removed `ncipollo/release-action`, added `fail-fast: false`, installed `libnetcdf-dev` for macOS, and excluded `macos-latest` with Python 3.8.
`.gitignore`	Added `coverage.*.xml` to ignore coverage reports.
`sonar-project.properties`	Added source/test directories, disabled SCM exclusions, specified Python versions, updated coverage paths, and changed `sonar.sources` to `xcompact3d_toolbox`.

Amidst the code's dance and play,
Changes weave a vibrant array.
Tags and tests, a harmonious sight,
MacOS and Python, in the light.
Sonar's gaze, keen and bright,
Code evolves, a magical flight!
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 713221e and 7003ab4.

Files ignored due to path filters (2)

docs/_config.yml is excluded by !**/*.yml
hatch.toml is excluded by !**/*.toml

Files selected for processing (3)

.github/workflows/ci.yaml (2 hunks)
.gitignore (1 hunks)
sonar-project.properties (1 hunks)

Files skipped from review due to trivial changes (2)

.github/workflows/ci.yaml
.gitignore

coderabbitai · 2024-05-15T22:03:45Z

sonar-project.properties

@@ -1,4 +1,8 @@
 sonar.organization=fschuch
 sonar.projectKey=fschuch_xcompact3d_toolbox

+sonar.sources=xcompacted_toolbox


Correct the source directory path.

The source directory path should be xcompact3d_toolbox instead of xcompacted_toolbox.

- sonar.sources=xcompacted_toolbox + sonar.sources=xcompact3d_toolbox

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

sonar.sources=xcompacted_toolbox

sonar.sources=xcompact3d_toolbox

sonar-project.properties

coderabbitai · 2024-05-15T22:03:45Z

sonar-project.properties

+sonar.sources=xcompacted_toolbox
+sonar.tests=tests
+
+sonar.scm.exclusions.disabled=true


Add a comment to explain the purpose of disabling SCM exclusions.

Adding a comment can help future maintainers understand why SCM exclusions are disabled.

+ # Disable SCM exclusions to include all files in the analysis sonar.scm.exclusions.disabled=true

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

sonar.scm.exclusions.disabled=true

# Disable SCM exclusions to include all files in the analysis

sonar.scm.exclusions.disabled=true

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7003ab4 and 4900abd.

Files ignored due to path filters (2)

docs/_config.yml is excluded by !**/*.yml
hatch.toml is excluded by !**/*.toml

Files selected for processing (3)

.github/workflows/ci.yaml (2 hunks)
.gitignore (1 hunks)
sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (3)

.github/workflows/ci.yaml
.gitignore
sonar-project.properties

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4900abd and c30e7e8.

Files ignored due to path filters (2)

docs/_config.yml is excluded by !**/*.yml
hatch.toml is excluded by !**/*.toml

Files selected for processing (3)

.github/workflows/ci.yaml (4 hunks)
.gitignore (1 hunks)
sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (3)

.github/workflows/ci.yaml
.gitignore
sonar-project.properties

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c30e7e8 and 7696dac.

Files ignored due to path filters (2)

docs/_config.yml is excluded by !**/*.yml
hatch.toml is excluded by !**/*.toml

Files selected for processing (3)

.github/workflows/ci.yaml (3 hunks)
.gitignore (1 hunks)
sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (3)

.github/workflows/ci.yaml
.gitignore
sonar-project.properties

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7696dac and 526ad03.

Files ignored due to path filters (2)

docs/_config.yml is excluded by !**/*.yml
hatch.toml is excluded by !**/*.toml

Files selected for processing (3)

.github/workflows/ci.yaml (3 hunks)
.gitignore (1 hunks)
sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (3)

.github/workflows/ci.yaml
.gitignore
sonar-project.properties

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 526ad03 and 7f181ef.

Files selected for processing (1)

.github/workflows/ci.yaml (3 hunks)

Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yaml

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7f181ef and b4f6fdb.

Files ignored due to path filters (1)

hatch.toml is excluded by !**/*.toml

Files selected for processing (1)

sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (1)

sonar-project.properties

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b4f6fdb and 6c9878c.

Files ignored due to path filters (1)

pyproject.toml is excluded by !**/*.toml

Files selected for processing (1)

sonar-project.properties (1 hunks)

Files skipped from review as they are similar to previous changes (1)

sonar-project.properties

sonarqubecloud · 2024-05-22T23:44:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

coderabbitai bot reviewed May 15, 2024

View reviewed changes

fschuch force-pushed the fix-sonar-cloud branch from 7003ab4 to 4900abd Compare May 15, 2024 22:05

coderabbitai bot reviewed May 15, 2024

View reviewed changes

fschuch force-pushed the fix-sonar-cloud branch 4 times, most recently from c30e7e8 to 0cc18e7 Compare May 15, 2024 22:32

coderabbitai bot reviewed May 15, 2024

View reviewed changes

fschuch force-pushed the fix-sonar-cloud branch 3 times, most recently from ecde6c7 to 7696dac Compare May 16, 2024 12:34

coderabbitai bot reviewed May 16, 2024

View reviewed changes

ci: fix sonarcloud

526ad03

fschuch force-pushed the fix-sonar-cloud branch from 7696dac to 526ad03 Compare May 16, 2024 12:47

coderabbitai bot reviewed May 16, 2024

View reviewed changes

coderabbitai bot reviewed May 22, 2024

View reviewed changes

wip

e37cc04

fschuch force-pushed the fix-sonar-cloud branch from 7f181ef to e37cc04 Compare May 22, 2024 23:11

wip

b4f6fdb

coderabbitai bot reviewed May 22, 2024

View reviewed changes

fschuch added 2 commits May 22, 2024 20:28

wip

3c44d15

wip

6c9878c

coderabbitai bot reviewed May 22, 2024

View reviewed changes

fschuch merged commit 7fb58f4 into main May 24, 2024
25 checks passed

fschuch deleted the fix-sonar-cloud branch May 24, 2024 21:19

coderabbitai bot mentioned this pull request Dec 16, 2024

Dropped support for Python 3.8 #73

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sonarcloud #39

Fix sonarcloud #39

fschuch commented May 15, 2024

coderabbitai bot commented May 15, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot May 15, 2024

coderabbitai bot May 15, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

sonarqubecloud bot commented May 22, 2024

	sonar.sources=xcompacted_toolbox
	sonar.sources=xcompact3d_toolbox

	sonar.scm.exclusions.disabled=true
	# Disable SCM exclusions to include all files in the analysis
	sonar.scm.exclusions.disabled=true

Fix sonarcloud #39

Fix sonarcloud #39

Conversation

fschuch commented May 15, 2024

coderabbitai bot commented May 15, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot May 15, 2024

Choose a reason for hiding this comment

coderabbitai bot May 15, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented May 22, 2024

Quality Gate passed

coderabbitai bot commented May 15, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)