-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Dart/Flutter library setup documentation #899
Conversation
Hi! Thanks for opening this pull request! 😄 |
Good job, looking forward to it! |
Hi, this PR is getting pretty close to done (just have a few pages left to write), so if you want to take a quick first look at the PR (since it is getting pretty massive), thoughts/recommendations would be welcome! Here's what I have left to write before I would consider this PR done:
|
In the future, it'd probably be a good idea for someone to make a mason brick to simplify the process of creating a library with FRB. A lot of the setup instructions documented here are boilerplate, but some also talk about how/why things work the way they do. |
@fzyzcjy Ready for review! |
IIRC @Desdaemon has made a brick for the non-library case btw
Reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job - this documentation is quite elaborated! Only a few nits and ready to merge :)
@all-contributors please add @GregoryConrad for doc |
I've put up a pull request to add @GregoryConrad! 🎉 |
@all-contributors please add @GregoryConrad for code (given that there are quite a bit of scripts in the doc - IMHO they should be categorized as code) |
I've put up a pull request to add @GregoryConrad! 🎉 |
Hi! Congrats on merging your first pull request! 🎉 |
Fixes #845