Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected thrust command to move the kth_freeflyer spacecraft in gazebo_test-cases/#1624 #2565

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Mechazo11
Copy link

@Mechazo11 Mechazo11 commented Sep 1, 2024

🦟 Bug fix

Corrected command to move the kth_freeflyer spacecraft testbed in gazebo_test-cases ticket #1624

Fixes: Spacecraft remained immobile after actuation commands to one of its thrusters was sent.

Summary

To test ground_spacecraft_testbed.sdf for the upcoming Ionic release, the embedded in the comment section of ground_spacecraft_testbed.sdf is for the DART spacecraft. I have updated it for the KTH_FREEFLYER platform based on the topics published once the simulation starts. See #1624 for a video that shows the moving in the world.

Corrected command: gz topic -p 'normalized:[1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0]' -t /kth_freeflyer/command/duty_cycle --msgtype gz.msgs.Actuators


Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes. I tested your new instructions and they worked 🎉

However, it'd be great of you could sign-off on your commits as described here

@arjo129 arjo129 self-assigned this Sep 2, 2024
@Mechazo11
Copy link
Author

Hi @arjo129 thanks for the tutorial link. This is the first time I did a DCO.

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick iteration time. LGTM.

@ahcorde ahcorde merged commit 34efaf1 into gazebosim:gz-sim8 Sep 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants