Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Footer Social Icons #35

Closed
gbowne1 opened this issue Jun 17, 2023 · 3 comments · Fixed by #47
Closed

[BUG] Footer Social Icons #35

gbowne1 opened this issue Jun 17, 2023 · 3 comments · Fixed by #47
Assignees
@adeleke5140
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberbest The hacktoberfest label help wanted Extra attention is needed question Further information is requested
Milestone
Finish v1.0 of Fr...

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Jun 17, 2023

The footer social icons no longer have their styling and colorization.

The links appear to be fine and working.
@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jun 17, 2023
@gbowne1 gbowne1 added this to the Finish v1.0 of Frontend milestone Jun 17, 2023
@gbowne1 gbowne1 added the hacktoberbest The hacktoberfest label label Oct 4, 2023
@gbowne1 gbowne1 mentioned this issue Oct 5, 2023
Closed
@adeleke5140
Copy link
Contributor

I want to solve this next.

What styling and colorization should the icons have?

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 22, 2023

@adeleke5140

See https://user-images.githubusercontent.com/47549872/232705889-4d3e2950-f2b2-4ee2-946a-4240ca0ea5ed.png

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 22, 2023

You might as well fix #42 at the same time.

@adeleke5140 adeleke5140 mentioned this issue Oct 24, 2023
Merged
@gbowne1 gbowne1 linked a pull request Oct 24, 2023 that will close this issue
Fix/footer issues #47
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adeleke5140 adeleke5140

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers hacktoberbest The hacktoberfest label help wanted Extra attention is needed question Further information is requested
Projects
Personal Site Project (gbowne1.com)
Status: Done
Milestone
Finish v1.0 of Frontend
Development

Successfully merging a pull request may close this issue.

Fix/footer issues adeleke5140/gbowne1site_react
2 participants
@adeleke5140 @gbowne1