Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Fix the footer #42

Closed
gbowne1 opened this issue Oct 5, 2023 · 11 comments · Fixed by #47
Closed

[TODO] Fix the footer #42

gbowne1 opened this issue Oct 5, 2023 · 11 comments · Fixed by #47
Assignees
Labels
bug Something isn't working hacktoberbest The hacktoberfest label help wanted Extra attention is needed

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Oct 5, 2023

The footer has a number of issues..

The app backround is too light to tell any significant issue. The footer background is white, but has gray bars across the icons and the copyright section.

The social media icons somehow lost their colorization #35 and I would like to use the icons' official colorization, and the Instagram icon should use the same colorization it uses on their site/app.

I also feel like the footer especially is way too tall, and the icons do not have good separation, especially if someone looked at it on a mobile device and tried fat fingering it with big fingers. Clicking on Desktop view would be fine but, on mobile would be not that good.

Separate and a minor issue is that there is ~5-10px of margin/padding on the left side of the view all the way down.. that also affects the footer.

@gbowne1 gbowne1 added bug Something isn't working help wanted Extra attention is needed hacktoberbest The hacktoberfest label labels Oct 5, 2023
@r0ld3x
Copy link

r0ld3x commented Oct 22, 2023

assign me.

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 22, 2023

The current footer is:
Screenshot 2023-10-21 at 19-35-23 React App

It's a bit wonky. The background is messed up. It has two extremely light gray bars going across what looks like a extremely white background, and it is so bad that the color difference is hard to see.

@adeleke5140
Copy link
Contributor

Alright, I will get started with this as well.

@adeleke5140
Copy link
Contributor

@gbowne1 How did the footer look like before these issues occurred?
I would like to know so I know the appropriate change to make.

@adeleke5140
Copy link
Contributor

This is the change I have made. Do you want the copyright and your social links at the centre instead?

And are you okay with the white background color?
Screenshot 2023-10-22 at 10 40 40

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 22, 2023

Yes they should be centered.

I want to implement theme / mode toggle too for light and dark mode.

I thought about using a medium gray background for the footer so I would go with that instead of white.

@adeleke5140
Copy link
Contributor

Alright. What is the hex value for the medium gray background?

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 23, 2023

I would think any medium gray in the #6xxxxx - #9xxxxx space would work.. perhaps something in the #7xxxxx range would work best.

@adeleke5140
Copy link
Contributor

Oh, I assumed you had a specific hex value in mind? I am not that great with colors.

@gbowne1
Copy link
Owner Author

gbowne1 commented Oct 23, 2023

@adeleke5140 no, I don't have any specific color in mind.

@adeleke5140
Copy link
Contributor

Alright. got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberbest The hacktoberfest label help wanted Extra attention is needed
Development

Successfully merging a pull request may close this issue.

3 participants