-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] Fix the footer #42
Comments
assign me. |
Alright, I will get started with this as well. |
@gbowne1 How did the footer look like before these issues occurred? |
Yes they should be centered. I want to implement theme / mode toggle too for light and dark mode. I thought about using a medium gray background for the footer so I would go with that instead of white. |
Alright. What is the hex value for the medium gray background? |
I would think any medium gray in the #6xxxxx - #9xxxxx space would work.. perhaps something in the #7xxxxx range would work best. |
Oh, I assumed you had a specific hex value in mind? I am not that great with colors. |
@adeleke5140 no, I don't have any specific color in mind. |
Alright. got it. |
The footer has a number of issues..
The app backround is too light to tell any significant issue. The footer background is white, but has gray bars across the icons and the copyright section.
The social media icons somehow lost their colorization #35 and I would like to use the icons' official colorization, and the Instagram icon should use the same colorization it uses on their site/app.
I also feel like the footer especially is way too tall, and the icons do not have good separation, especially if someone looked at it on a mobile device and tried fat fingering it with big fingers. Clicking on Desktop view would be fine but, on mobile would be not that good.
Separate and a minor issue is that there is ~5-10px of margin/padding on the left side of the view all the way down.. that also affects the footer.
The text was updated successfully, but these errors were encountered: