Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/footer issues #47

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Fix/footer issues #47

merged 5 commits into from
Oct 24, 2023

Conversation

adeleke5140
Copy link
Contributor

@adeleke5140 adeleke5140 commented Oct 24, 2023 •
edited
Loading

This PR will fix the footer and footer icon styling issues.

Here is how the footer looked before:

Screenshot 2023-10-24 at 13 22 14 ng Screenshot 2023-10-24 at 13.22.14.png

Here is how it looks now:
Screenshot 2023-10-24 at 13 22 38

It effectively closes #42 and #35.

I'm working on fixing the merge conflicts.

@gbowne1 gbowne1 linked an issue Oct 24, 2023 that may be closed by this pull request
Minor issues I found while in the browser console #45
Open
@gbowne1 gbowne1 removed a link to an issue Oct 24, 2023
Minor issues I found while in the browser console #45
Open
@gbowne1 gbowne1 linked an issue Oct 24, 2023 that may be closed by this pull request
[BUG] Footer Social Icons #35
Closed
@gbowne1 gbowne1 added enhancement New feature or request help wanted Extra attention is needed labels Oct 24, 2023
@gbowne1 gbowne1 added this to the Finish v1.0 of Frontend milestone Oct 24, 2023
@gbowne1 gbowne1 self-requested a review October 24, 2023 17:32
gbowne1
gbowne1 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@gbowne1 gbowne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked out this change locally for testing and review for merge

This change once applied looks great and fixed the footer and some small issues we had with the app/site

Approving for merge and merging

@gbowne1 gbowne1 merged commit e43b637 into gbowne1:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbowne1 gbowne1 gbowne1 approved these changes

Assignees

@adeleke5140 adeleke5140

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Personal Site Project (gbowne1.com)
Status: Done
Milestone
Finish v1.0 of Frontend
Development

Successfully merging this pull request may close these issues.

[TODO] Fix the footer [BUG] Footer Social Icons
2 participants
@adeleke5140 @gbowne1