Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove skip for SoftmaxLMC test_predictions #493

Merged
merged 1 commit into from
Feb 10, 2025
+0 −5
Merged

tests: remove skip for SoftmaxLMC test_predictions #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/units/classification/test_categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@
Tests for the CategoricalClassification decorator.
"""

import platform
from unittest import expectedFailure

import pytest
import sklearn
import torch
from gpytorch.mlls import VariationalELBO
Expand Down Expand Up @@ -205,9 +203,6 @@ def setUp(self) -> None:
rng=self.rng,
)

# TODO(rg): Investigate why this fails on Mac
# https://github.com/gchq/Vanguard/issues/473
@pytest.mark.skipif(platform.system() == "Darwin", reason="Currently fails on Mac")
def test_predictions(self) -> None:
"""Predict on a test dataset, and check the predictions are reasonably accurate."""
# This test failed for eight different seeds in a row when fitting for only 10 iterations - this one really
Expand Down
Loading