New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: remove skip for SoftmaxLMC test_predictions #493

Merged

tp832944 merged 1 commit into main from fix/softmax-lmc-on-mac

Feb 10, 2025

Contributor

rg936672 commented Feb 5, 2025 •

edited

Loading

PR Type

Tests

Description

Closes #473. Turns out the bug was already fixed while loosening the tests in #482.

How Has This Been Tested?

Test now passes on Mac.

Does this PR introduce a breaking change?

No.

Checklist before requesting a review

I have made sure that my PR is not a duplicate.
My code follows the style guidelines of this project.
I have commented my code, particularly in hard-to-understand areas.
I have performed a self-review of my code.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
Any dependent changes have been merged and published in downstream modules.


          tests: remove skip for SoftmaxLMC test_predictions

44c868b

Refs: #473

rg936672 marked this pull request as ready for review

February 5, 2025 12:07

tp832944 self-assigned this

tp832944 approved these changes

View reviewed changes

Contributor

tp832944 commented Feb 10, 2025

Ignoring temporarily broken external link in docs.

tp832944 merged commit 1ece6f4 into main

29 of 30 checks passed

tp832944 deleted the fix/softmax-lmc-on-mac branch

February 10, 2025 09:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet