build: Bump node to 22.5.1 #13118
Merged
build: Bump node to 22.5.1 #13118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson and
chargome
and removed request for
a team
chargome
approved these changes
Aug 2, 2024
size-limit report 📦
|
AbhiPrasad
added a commit
that referenced
this pull request
Aug 14, 2024
This reverts commit 345dd74.
AbhiPrasad
added a commit
that referenced
this pull request
Aug 14, 2024
Reverts #13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.
Zen-cronic
pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Aug 26, 2024
Reverts getsentry#13118 There has been quite a bit of segmentation faults in CI after this PR was merged. I tried spending time to look into this in more detail, but it didn't get far, so not worrying about this too much for now. Let's revert and re-examine later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 22 brings with it:
node --runto run scripts (fast)node --watchglobinnode:fswhich should allow us to remove a couple of our dependencies and clean up our scripts.