ci: Show what size limit jobs exceeded the limit #13532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/size-limit-exceeded
branch
from
18cbad9
to
2330269
Compare
size-limit report 📦
|
mydea
force-pushed
the
fn/size-limit-exceeded
branch
from
3247805
to
b4cb6fd
Compare
Lms24
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Nice! I like it a lot! Perhaps this is something we could also more clearly point out in the size-limit CI logs? There it's especially hard to find the entry that caused the job to fail. But maybe it's also just me who checks the logs rather than trusting the table 😅
s1gr1d
approved these changes
Sep 3, 2024
I'll add a debug log in addition, too! 👍 |
mydea
force-pushed
the
fn/size-limit-exceeded
branch
from
b4cb6fd
to
5b05303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that it was a bit annoying, when we exceeded the size limit, to find out why/what has failed.
Now, it should show in the GH comment which specific check has failed, and what the current limit is:
While I was at this, I also streamlined the code a bit, extracted it a bit into utils to de-clutter stuff, and fixed/improved some debug logging issues (e.g. the log group was not correctly closed before, ...)