test(loader): Update Loader Script & test error in sentryOnLoad
#13952
+50
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Good change! Left a comment in getsentry/sentry#78993 (comment) but apart from that I think this is good to go.
| async ({ getLocalTestUrl, page }) => { | ||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| const req = await waitForErrorRequestOnUrl(page, url); | ||
|
|
There was a problem hiding this comment.
l: we could assert on the console output here so that we ensure that the error is logged, wdyt?
There was a problem hiding this comment.
I updated this to assert on the error message!
mydea
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 14, 2024
If a user has an error in their `sentryOnLoad` function for the Loader Script, we do try-catch it today, but we stop any further processing, leading to possible issues down the line (e.g. errors not being sent to Sentry etc). This PR changes this so that we catch errors in this first, and continue if it happens. This means that we'll still do the default `Sentry.init()` and send the error that triggered lazy loading to Sentry - this was previously swallowed by the catch. Closes getsentry/sentry-javascript#13939 Test added here: getsentry/sentry-javascript#13952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the loader & adds tests for getsentry/sentry#78993