fix(loader): Catch errors in sentryOnLoad
separately
#78993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has an error in their
sentryOnLoad
function for the Loader Script, we do try-catch it today, but we stop any further processing, leading to possible issues down the line (e.g. errors not being sent to Sentry etc).This PR changes this so that we catch errors in this first, and continue if it happens. This means that we'll still do the default
Sentry.init()
and send the error that triggered lazy loading to Sentry - this was previously swallowed by the catch.Closes getsentry/sentry-javascript#13939
Test added here: getsentry/sentry-javascript#13952