-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): add replay_id uuid processors to config #5791
Conversation
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration discover : 0008_discover_add_replay_id
Local op: ALTER TABLE discover_local ADD COLUMN IF NOT EXISTS replay_id Nullable(UUID) AFTER span_id;
Distributed op: ALTER TABLE discover_dist ADD COLUMN IF NOT EXISTS replay_id Nullable(UUID) AFTER span_id;
-- end forward migration discover : 0008_discover_add_replay_id
-- backward migration discover : 0008_discover_add_replay_id
Distributed op: ALTER TABLE discover_dist DROP COLUMN IF EXISTS replay_id;
Local op: ALTER TABLE discover_local DROP COLUMN IF EXISTS replay_id;
-- end backward migration discover : 0008_discover_add_replay_id |
@@ -157,6 +157,7 @@ schema: | |||
}, | |||
{ name: app_start_type, type: String }, | |||
{ name: profile_id, type: UUID, args: { schema_modifiers: [nullable] } }, | |||
{ name: replay_id, type: UUID, args: { schema_modifiers: [nullable] } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed for transactions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you also need to add a replay_id column like this to discover.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we want to query on this column which exists in the transactions dataset
@@ -88,6 +88,7 @@ schema: | |||
args: { schema_modifiers: [nullable], size: 64 }, | |||
}, | |||
{ name: deleted, type: UInt, args: { size: 8 } }, | |||
{ name: trace_id, type: UUID, args: { schema_modifiers: [nullable] } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we adding trace_id? Isn't this pr a followup to the migration where you added replay_id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also have to add a column to the entities/discover.yaml file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch, should have been replay_id
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 456 tests with View the full list of failed tests
|
PR reverted: cdfd3ba |
This reverts commit 8ede52a. Co-authored-by: JoshFerge <[email protected]>
split out from #5787