Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): add replay_id uuid processors to config #5791

Merged
merged 10 commits into from
Apr 18, 2024
Merged

feat(replays): add replay_id uuid processors to config #5791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
617b033
feat(replays): add migration for replay_id in discover
JoshFerge Apr 17, 2024
8d4ea69
feat(replays): add replay_id uuid processors to config
JoshFerge Apr 17, 2024
f78aa52
Update discover.yaml
JoshFerge Apr 18, 2024
01c197b
Merge branch 'master' into jferg/replay-idp-processors
JoshFerge Apr 18, 2024
aec9df3
Update errors_ro.yaml
JoshFerge Apr 18, 2024
d8dca7c
Update errors.yaml
JoshFerge Apr 18, 2024
01cad76
Update group_loader.py
JoshFerge Apr 18, 2024
6d2764a
Delete snuba/snuba_migrations/discover/0008_discover_add_replay_id.py
JoshFerge Apr 18, 2024
2da431b
Update group_loader.py
JoshFerge Apr 18, 2024
899898a
Merge branch 'master' into jferg/replay-idp-processors
JoshFerge Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions snuba/datasets/configuration/discover/storages/discover.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ schema:
args: { schema_modifiers: [nullable], size: 64 },
},
{ name: deleted, type: UInt, args: { size: 8 } },
{ name: replay_id, type: UUID, args: { schema_modifiers: [nullable] } }
]
local_table_name: discover_local
dist_table_name: discover_dist
Expand Down Expand Up @@ -115,9 +116,7 @@ query_processors:
column_name: tags
- processor: UUIDColumnProcessor
args:
columns: !!set
trace_id: null
event_id: null
columns: [event_id, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
6 changes: 1 addition & 5 deletions snuba/datasets/configuration/events/storages/errors.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ allocation_policies:
getsentry.tasks.backfill_grouping_records:
max_threads: 2
concurrent_limit: 4

query_processors:
- processor: UniqInSelectAndHavingProcessor
- processor: TupleUnaliaser
Expand All @@ -303,10 +302,7 @@ query_processors:
- processor: UserColumnProcessor
- processor: UUIDColumnProcessor
args:
columns: !!set
event_id: null
primary_hash: null
trace_id: null
columns: [event_id, primary_hash, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
7 changes: 1 addition & 6 deletions snuba/datasets/configuration/events/storages/errors_ro.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,6 @@ allocation_policies:
getsentry.tasks.backfill_grouping_records:
max_threads: 2
concurrent_limit: 4


query_processors:
- processor: UniqInSelectAndHavingProcessor
- processor: TupleUnaliaser
Expand All @@ -302,10 +300,7 @@ query_processors:
- processor: UserColumnProcessor
- processor: UUIDColumnProcessor
args:
columns: !!set
primary_hash: null
event_id: null
trace_id: null
columns: [event_id, primary_hash, trace_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: !!set
Expand Down
3 changes: 2 additions & 1 deletion snuba/datasets/configuration/transactions/storages/transactions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ schema:
},
{ name: app_start_type, type: String },
{ name: profile_id, type: UUID, args: { schema_modifiers: [nullable] } },
{ name: replay_id, type: UUID, args: { schema_modifiers: [nullable] } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed for transactions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you also need to add a replay_id column like this to discover.yaml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we want to query on this column which exists in the transactions dataset

]
local_table_name: transactions_local
dist_table_name: transactions_dist
Expand Down Expand Up @@ -202,7 +203,7 @@ query_processors:
trace.span_id: span_id
- processor: UUIDColumnProcessor
args:
columns: [event_id, trace_id, profile_id]
columns: [event_id, trace_id, profile_id, replay_id]
- processor: HexIntColumnProcessor
args:
columns: [span_id]
Expand Down
Loading